Skip to content

acc: log bundle run output in apps/inline_config instead of discarding it - #7498

Merged
denik merged 1 commit into
mainfrom
fix-apps-inline-config-hidden-run-error
Nov 12, 2026
Merged

denik merged 1 commit into
mainfrom
fix-apps-inline-config-hidden-run-error

Conversation

@denik

@denik denik commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Changes

acceptance/bundle/resources/apps/inline_config sent bundle run myapp output to /dev/null. When bundle run fails (the app compute start or the app deployment fails on the backend, roughly 1-2% of cloud runs), the script exits with code 1 and the test output shows no reason. The root script.cleanup (rm -fr .databricks .gitignore) only runs when the script succeeds, so the failure was reported as "Test produced unexpected files: .databricks/.gitignore", which pointed at the wrong thing.

This PR writes the output to LOG.run_app instead, the same way bundle/apps/source_code_path_update does it. The harness prints LOG.* files in the test log, so the next failure shows the real bundle run error. output.txt stays unchanged because the progress lines and the app URL still stay out of it.

Judgment call: I did not add a retry or ignore .databricks. The leftover files only come from the cleanup being skipped, so ignoring them would hide nothing useful and fix nothing. We can't tell yet whether retrying is right because the real error was never recorded. With this change it will be, and the failure can then be grouped with the matching backend app error.

Tests

  • Local: go test ./acceptance -run TestAccept/bundle/resources/apps/inline_config passes.
  • Cloud (AWS): TestAccept/bundle/resources/apps/inline_config/DMS=true passes. The log shows bundle run starting the stopped compute and then deploying.

Dashboard:

error verbatim snippet
error/1268 Test produced unexpected files:
.databricks/.gitignore
.databricks/bundle/default/deployment.json (after Destroy: 1 deleted / Exit code: 1, with the apps get-deployment step missing)

This pull request and its description were written by Isaac.

…g it

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 11, 2026
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: 5c1946d2b | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=0 coverage=2 failing=0
test branch main (56dd253) latest (v1.26.0)
TestAccept/bundle/resources/apps/inline_config/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/apps/inline_config/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 5c1946d

Run: 43073831005

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 274 15 14:52
✅​ aws-windows-latest-4core-16gb 276 13 9:43
✅​ azure linux-2core-8gb 273 15 13:31
🔄​ azure-windows-latest-4core-16gb 3 272 13 10:39
🔄​ gcp linux-2core-8gb 1 273 15 17:21
✅​ gcp-windows-latest-4core-16gb 276 13 10:36
Test Name azure-windows-latest-4core-16gb gcp linux-2core-8gb
🔄​ TestSyncIncrementalSyncFileToPythonNotebook 🔄​f 🔄​f
🔄​ TestSyncNestedFolderSync 🔄​f ✅​p
🔄​ TestSyncNestedSpacePlusAndHashAreEscapedSync 🔄​f ✅​p
Top 33 slowest tests (at least 2 minutes):
duration env testname
5:54 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=true
5:30 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=
4:51 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=true
4:27 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
4:21 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=true
4:20 gcp linux-2core-8gb TestImportDirDoesNotOverwrite
4:17 gcp linux-2core-8gb TestAccept/bundle/resources/apps/inline_config/DMS=true
4:13 aws linux-2core-8gb TestAccept/bundle/resources/apps/inline_config/DMS=
3:57 aws linux-2core-8gb TestAccept
3:56 aws linux-2core-8gb TestAccept/bundle/resources/apps/inline_config/DMS=true
3:55 gcp linux-2core-8gb TestAccept
3:52 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=
3:42 azure linux-2core-8gb TestAccept
3:39 gcp-windows-latest-4core-16gb TestAccept
3:36 gcp linux-2core-8gb TestAccept/bundle/resources/apps/inline_config/DMS=
3:33 aws-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
3:25 aws-windows-latest-4core-16gb TestAccept
3:25 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:14 azure linux-2core-8gb TestAccept/bundle/resources/apps/inline_config/DMS=true
3:03 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:02 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:00 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:59 azure-windows-latest-4core-16gb TestAccept
2:59 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=
2:57 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:36 azure linux-2core-8gb TestAccept/bundle/resources/apps/inline_config/DMS=
2:28 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
2:23 gcp-windows-latest-4core-16gb TestSyncFullFileSync
2:17 gcp-windows-latest-4core-16gb TestImportDirWithOverwriteFlag
2:09 gcp-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
2:06 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
2:01 aws linux-2core-8gb TestImportDirDoesNotOverwrite
2:01 aws-windows-latest-4core-16gb TestExportDir

@denik
denik marked this pull request as ready for review November 11, 2026 18:29
@denik
denik requested review from a team as code owners November 11, 2026 18:29
@denik
denik enabled auto-merge November 11, 2026 18:29
@andrewnester
andrewnester self-requested a review November 12, 2026 08:58
@denik
denik added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 28bbf47 Nov 12, 2026
28 checks passed
@denik
denik deleted the fix-apps-inline-config-hidden-run-error branch November 12, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories, DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants