Repository navigation
acc: log bundle run output in apps/inline_config instead of discarding it - #7498
Merged
Merged
Conversation
…g it Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: 5c1946d
Top 33 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 11, 2026 18:29
denik
enabled auto-merge
November 11, 2026 18:29
andrewnester
self-requested a review
November 12, 2026 08:58
andrewnester
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
acceptance/bundle/resources/apps/inline_configsentbundle run myappoutput to/dev/null. Whenbundle runfails (the app compute start or the app deployment fails on the backend, roughly 1-2% of cloud runs), the script exits with code 1 and the test output shows no reason. The rootscript.cleanup(rm -fr .databricks .gitignore) only runs when the script succeeds, so the failure was reported as "Test produced unexpected files: .databricks/.gitignore", which pointed at the wrong thing.This PR writes the output to
LOG.run_appinstead, the same waybundle/apps/source_code_path_updatedoes it. The harness printsLOG.*files in the test log, so the next failure shows the realbundle runerror. output.txt stays unchanged because the progress lines and the app URL still stay out of it.Judgment call: I did not add a retry or ignore
.databricks. The leftover files only come from the cleanup being skipped, so ignoring them would hide nothing useful and fix nothing. We can't tell yet whether retrying is right because the real error was never recorded. With this change it will be, and the failure can then be grouped with the matching backend app error.Tests
go test ./acceptance -run TestAccept/bundle/resources/apps/inline_configpasses.TestAccept/bundle/resources/apps/inline_config/DMS=truepasses. The log showsbundle runstarting the stopped compute and then deploying.Dashboard:
Test produced unexpected files:.databricks/.gitignore.databricks/bundle/default/deployment.json(afterDestroy: 1 deleted/Exit code: 1, with theapps get-deploymentstep missing)This pull request and its description were written by Isaac.