Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: 70068a7
Top 6 slowest tests (at least 2 minutes):
|
pietern
force-pushed
the
execute-args
branch
3 times, most recently
from
November 12, 2026 13:51
d823fdf to
6426811
Compare
Lets Execute resolve the target command before running cobra, which lazily added subcommands need. nil args now mean no arguments instead of falling back to the process arguments. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
force-pushed
the
execute-args
branch
from
November 13, 2026 11:55
6426811 to
70068a7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
root.Executenow takes the args to run instead of reading them from the command, where cobra falls back toos.Argsif they were never set.nilmeans no arguments.mainpassesos.Args[1:], and tests pass their args directly instead of callingSetArgsfirst.The next PR needs this: it has to see the args before cobra runs.
Tests
New unit test
TestExecuteWithNilArgsRunsWithoutArgschecks that nil means no arguments; existing unit and acceptance tests cover the callers.This pull request and its description were written by Isaac.