Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: c9f6c24
Top 6 slowest tests (at least 2 minutes):
|
pietern
force-pushed
the
sync-options-values
branch
2 times, most recently
from
November 12, 2026 13:51
7417e19 to
76a7f2e
Compare
The sync and bundle sync option builders took the command only to read its context, output type, and stdout. Pass those instead, so their tests no longer attach the command to root.New() to resolve the root flags. The argument count check stays in RunE; its cases move to the sync-without-args acceptance test. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
force-pushed
the
sync-options-values
branch
from
November 13, 2026 11:55
76a7f2e to
c9f6c24
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks syncanddatabricks bundle syncbuild their options from a*cobra.Command, so their tests created a full root command withroot.New()to get there. The builders now take only what they use: the context, output type, stdout, and args or bundle. The tests call them directly.The two-argument check moves into
RunE, and the builder returns a plain error for a wrong number of args. A new acceptance test coverssyncwith zero, one, and three arguments. Since the unit tests can no longer check that the root's--outputreachessync, the dry-run acceptance test now runs it with-o json.This reduces usage of
root.New()ahead of making it private later in this stack.Tests
Unit tests for both builders; new acceptance test
acceptance/cmd/sync-wrong-args; a JSON case inacceptance/cmd/sync/dryrun.This pull request and its description were written by Isaac.