Skip to content

aitools: drop the Proceed? confirm after the agent picker in install - #7478

Merged
anton-107 merged 1 commit into
mainfrom
aitools/drop-proceed-confirm
Nov 13, 2026
Merged

anton-107 merged 1 commit into
mainfrom
aitools/drop-proceed-confirm

Conversation

@anton-107

@anton-107 anton-107 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #7477.

Stacked on: aitools: never prompt a coding agent caller in install

Summary

databricks aitools install (interactive, no agents on the command line) no longer asks Proceed? after the agent picker. Agents that would be skipped are not offered in the picker, so choosing agents already confirms the plan. The install scope moves into the picker title, so it is visible before anything runs, and the plan summary after the picker shrinks to the scope line.

 install (interactive picker path)
-  promptAgentSelection     # "Select agents to set up", "enter to confirm"
+  promptAgentSelection     # "Select agents to set up (<scope> scope)", "enter to install"
   buildPlan
-  printPlanSummary         # "Plan (<scope> scope):" + one line per agent
-  promptProceed            # "Proceed?" — No => "Cancelled.", exit 0
-    if !proceed: funnel CANCELLED, return nil
   funnel PLAN_CONFIRMED
+  printInstallScope        # "Install scope: <scope>"
   install plugins / skills
  • promptProceed and defaultPromptProceed are removed. promptAgentSelection takes the scope for its title.
  • printPlanSummary becomes printInstallScope. Its per-agent lines repeated the picker, and its skip branch could no longer run.
  • The picker hint reads "space to toggle, enter to install", since Enter now starts the install.
  • Under --skills-only (and the databricks skills install alias), every found agent is labeled "skills" in the picker, skipped rows included, because that is what they get. The removed per-agent summary lines were the only place this showed before. In that mode an agent whose config dir exists also starts checked, so a plugin agent whose CLI is not on PATH is included, as in the non-interactive run.
  • PLAN_CONFIRMED is kept and still follows AGENTS_SELECTED right away; its comment in libs/telemetry/protos now says the picker selection is the confirmation.
  • TestInstallFunnelInteractiveCancel now cancels at the picker, which is the last prompt before the install.
  • Changelog fragment: .nextchanges/cli/aitools-install-drop-proceed-confirm.md.

Evidence

go test ./cmd/aitools/ -count=1 -v -run 'TestInstallFunnelInteractiveCancel|TestInstallFunnelEmptyPickerSelectionIsCancelled|TestInstallInteractivePickerInstallsPickedAgent|TestAgentPickerTitleNamesScope|TestPrintInstallScope|TestAgentChoicesSkillsOnly|TestInstallAgentCallerInPTYNeverPrompts' at this head: all pass.

  • TestInstallInteractivePickerInstallsPickedAgent mocks project scope (not the global default) and checks that the picker gets it, that Install scope: project follows the picker on stderr, and that the picked agent gets the plugin.
  • TestAgentChoicesSkillsOnlyLabelsPluginAgentsSkills checks that Claude Code is labeled "plugin" normally and "skills" under --skills-only. It fails without the label change.
  • TestAgentChoicesSkillsOnlyLabelsSkippedPluginAgentSkills checks that a skipped Codex CLI row under --skills-only --scope project reads skills · does not support project-scoped skills, and TestAgentChoicesSkillsOnlyPreselectsByConfigDir checks that Claude Code with no CLI on PATH starts checked under --skills-only only. Both fail without the change.
  • TestAgentPickerTitleNamesScope and TestPrintInstallScope pin the picker title and the scope line.
  • No test can see the removed confirm directly. With the old Proceed? in place, the picker test failed in a shell without a controlling terminal (huh: could not open a new TTY) and passed with one, because the confirm then read stdin and defaulted to Yes. So the test is named after what it checks.
  • go test ./cmd/aitools/... ./libs/telemetry/... and ./task test-exp-aitools pass at this head (Linux). No acceptance test drives the interactive picker, so no acceptance output changes.

Merge Danger

Door: two-way

Removes one prompt and shortens the text around the picker. Reverting the commit restores both.

Blast Radius: small

  • Interactive users can't decline after the picker any more. They cancel at the picker (Ctrl-C), which returns an error and records CANCELLED:USER_ABORTED instead of the old "Cancelled." with exit 0 and CANCELLED with no category.
  • The interactive output changes: the picker title gains (<scope> scope), its hint says enter to install, --skills-only rows say skills instead of plugin and are pre-checked by config dir, and the Plan (<scope> scope): block with one line per agent becomes a single Install scope: <scope> line.
  • Non-interactive runs, runs with agents named on the command line, and coding-agent callers are unchanged. They never reached this confirm.
  • Not tested on Windows or macOS, or with a real terminal.

This pull request and its description were written by Isaac.

@anton-107
anton-107 requested review from a team and lennartkats-db as code owners November 11, 2026 14:27
@anton-107 anton-107 added the ai-auto PRs made by AI loops & factories, label Nov 11, 2026
@anton-107
anton-107 requested a review from a team as a code owner November 11, 2026 14:27
@anton-107 anton-107 added the ai-auto PRs made by AI loops & factories, label Nov 11, 2026
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 3af19e5 to 2711bbe Compare November 11, 2026 14:33
@anton-107
anton-107 requested a review from a team as a code owner November 11, 2026 14:33
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 7c162ba to 593c4fe Compare November 11, 2026 14:34
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: e002fe4

Run: 43371274177

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 4:41
💚​ aws-windows-latest-4core-16gb 1 272 13 3:00
💚​ azure linux-2core-8gb 1 269 15 4:30
💚​ azure-windows-latest-4core-16gb 1 271 13 3:44
💚​ gcp linux-2core-8gb 1 270 15 4:30
💚​ gcp-windows-latest-4core-16gb 1 272 13 2:53
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 6 slowest tests (at least 2 minutes):
duration env testname
3:41 azure-windows-latest-4core-16gb TestAccept
3:26 azure linux-2core-8gb TestAccept
3:19 aws linux-2core-8gb TestAccept
3:19 gcp linux-2core-8gb TestAccept
2:59 aws-windows-latest-4core-16gb TestAccept
2:51 gcp-windows-latest-4core-16gb TestAccept

@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 2711bbe to 95f78a5 Compare November 11, 2026 16:53
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 593c4fe to deca41f Compare November 11, 2026 16:53
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 95f78a5 to 668167b Compare November 11, 2026 16:54
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from deca41f to e980d56 Compare November 11, 2026 16:55
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 668167b to eef5046 Compare November 11, 2026 16:57
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from e980d56 to e155c53 Compare November 11, 2026 16:57
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from eef5046 to d0c5cc6 Compare November 11, 2026 17:26

@simonfaltum simonfaltum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review from simonfaltum's review agent (pr-review skill) at e155c53. Each finding was verified against the code; simonfaltum may follow up.

Not approving yet: 1 blocking issue(s), tagged [blocking]; 2 open design questions.

This PR removes the interactive Proceed? confirm after the agent picker in databricks aitools install. The picker selection now counts as confirmation, the funnel cancel test moves to the picker, and a changelog fragment is added. The commit itself is correct: the picker already hides agents that would be skipped. However, the branch is built on an outdated revision of #7477. It conflicts with the current base, its diff undoes #7477's later fixes, and after a rebase the tests stop compiling until the leftover promptProceed override in TestInstallAgentCallerInPTYNeverPrompts is removed. There are also two open design questions: whether losing the clean decline is intended, and what to do with the plan summary and PLAN_CONFIRMED step that remain.

Questions

  1. With the confirm gone, an interactive user who sees the plan can no longer back out cleanly. Ctrl-C at the picker exits non-zero (USER_ABORTED), and an empty selection errors, where answering n used to print "Cancelled." and exit 0. Detected agents start checked, so a single Enter now installs plugins, writes state and cleans up legacy skills. aitools uninstall and completion install still ask Proceed?. Is losing the clean decline intended? Would you rather keep the confirm, drop it as here, or drop it and show the install scope in the picker title so the scope is still visible before anything runs?
  2. Now that nothing follows the plan summary, printPlanSummary repeats the picker right before the per-agent install lines, and its skip branch can no longer run. PLAN_CONFIRMED now fires unconditionally right after AGENTS_SELECTED, so the new funnel can't show how many users decline at the plan, and the proto comment ("confirmed, by the user or implicitly") no longer describes a real step. Should the summary stay as it is, shrink to just the scope line, or go? And should PLAN_CONFIRMED be kept, dropped or renamed, with the proto comment and any dashboards updated?

Comments outside the changed lines

  • [nice to have] .github/PULL_REQUEST_TEMPLATE.md: .agents/skills/pr-checklist/SKILL.md:48 says to follow .github/PULL_REQUEST_TEMPLATE.md exactly, with ## Changes, ## Why and ## Tests in that order and no invented sections such as ## Summary. This body uses ## Summary, ## Evidence and ## Merge Danger, and the agent-disclosure line is not italic as line 54 asks. Please restructure the body under the template headings (the evidence fits under ## Tests, the merge-danger notes under ## Why) and italicize the disclosure line.
  • [nit] cmd/aitools/install.go:184: The comment above the --output json flag check still says the flags are required "so no scope prompt, agent picker, or confirm is shown". Install no longer has a confirm, so a reader will look for a prompt that doesn't exist. Drop "or confirm".
  • [nit] cmd/aitools/funnel_test.go:277: TestInstallFunnelEmptyPickerSelectionIsCancelled says it "finishes CANCELLED like a declined confirm", but install no longer has a declined confirm. The (there is no "Proceed?" confirm) note at lines 239-240 also describes removed code rather than the test, so after merge it reads as history. Consider rewording both, for example: the picker is the last prompt before the install. Since TestInstallFunnelInteractiveCancel now drives the picker with an error, this test could also become a third row in that table: {name: "nothing selected", err: errNoAgentsSelected, want: "FINISHED:CANCELLED:"}.

Comment thread cmd/aitools/install_test.go Outdated
}
}

func TestInstallAgentCallerInPTYNeverPrompts(t *testing.T) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blocking] This branch is built on an older revision of #7477 (eef5046). aitools/no-prompts-for-agents has since been force-pushed (now d0c5cc6), and GitHub reports the PR as conflicting. Measured against the current base, the diff also undoes #7477's review fixes: it brings back the callerIsAgent seam and main_test.go's TestMain, drops startFunnel's interactive argument (agent callers in a PTY are reported Interactive=true again), removes isolateAgents(t) calls and the SDK source-URL comment, and restores stubLegacyCleanup. A rebase alone won't be enough: the new base's TestInstallAgentCallerInPTYNeverPrompts overrides promptProceed with t.Fatal("plan confirm shown to an agent caller"), and that override merges without a textual conflict, but this PR deletes promptProceed. I simulated the rebase and resolved the rename conflict, and go vet ./cmd/aitools/ then fails with install_test.go:873:17: undefined: promptProceed. Please rebase with git rebase --onto origin/aitools/no-prompts-for-agents eef5046e4, delete that override, and keep the base's isolateAgents(t) at the top of TestInstallInteractivePickerWithoutConfirm. CI is green only because it ran on the stale stack.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto the current aitools/no-prompts-for-agents (a791ac7). The diff against the base now only touches the confirm: the promptProceed override in TestInstallAgentCallerInPTYNeverPrompts is gone, isolateAgents(t) stays at the top of the picker test, and TestInstallFunnelInteractiveCancel follows the base's new funnel order (AGENTS_SELECTED fires after the picker, so a picker cancel ends at SCOPE_RESOLVED) and its "prompt failed" row passes an error already tagged by promptError, the way the real picker returns it. go vet ./cmd/aitools/ and go test ./cmd/aitools/... pass.

Comment thread cmd/aitools/install_test.go Outdated
}

func TestInstallInteractivePickerAndConfirm(t *testing.T) {
func TestInstallInteractivePickerWithoutConfirm(t *testing.T) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] As the PR description notes, TestInstallInteractivePickerWithoutConfirm also passes with the old confirm in place: without a terminal the confirm reads stdin and defaults to Yes. Its name and the // No "Proceed?" confirm follows the picker comment at line 379 claim something it can't detect. Either name it after what it checks (the picked agent gets the plugin) or make it fail if a prompt runs after the picker.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it to TestInstallInteractivePickerInstallsPickedAgent and dropped the // No "Proceed?" confirm follows the picker comment (a791ac7). Making it fail when a prompt runs after the picker would need a hook that this PR removes, so the name now says what it checks. On the parent it fails only without a controlling terminal (huh: could not open a new TTY); with one, the old confirm reads stdin and defaults to Yes.

@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch 2 times, most recently from 2e61f20 to 6251610 Compare November 11, 2026 19:30
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch 2 times, most recently from a791ac7 to a45b450 Compare November 11, 2026 19:42
@anton-107

Copy link
Copy Markdown
Contributor Author

Answers to the two questions in the review (a45b450):

  1. Losing the clean decline: intended. The confirm stays dropped, and the install scope now sits in the picker title (Select agents to set up (global scope)), so the scope is visible before anything runs. An interactive user backs out at the picker: Ctrl-C (CANCELLED:USER_ABORTED, non-zero exit) or an empty selection (CANCELLED, error). aitools uninstall and completion install keep their Proceed?. They remove or change existing setup, and they have no picker that already confirms the choice.

  2. Plan summary and PLAN_CONFIRMED. The summary shrinks to one Install scope: <scope> line after the picker. printPlanSummary becomes printInstallScope, so the per-agent lines that repeated the picker and the dead skip branch are gone. PLAN_CONFIRMED is kept. It is emitted right after AGENTS_SELECTED, because picking agents is the confirmation, and runs without the picker confirm implicitly. Its comment in libs/telemetry/protos/aitools_events.go now says so.

The two wording nits are also fixed: the --output json comment in install.go no longer mentions a confirm, and the funnel_test.go comments describe the picker as the last prompt instead of referring to the removed confirm. The empty-selection test stays separate, because it also checks that the error is errNoAgentsSelected. The PR body now describes the new behavior. I haven't moved it to the template headings yet.

@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 6251610 to bc7b149 Compare November 11, 2026 20:07
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from a45b450 to eb589c2 Compare November 11, 2026 20:07
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from bc7b149 to 4a46f77 Compare November 11, 2026 21:04
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from eb589c2 to df49877 Compare November 11, 2026 21:04
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from da4d9e2 to efae3db Compare November 12, 2026 09:00
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 914a32c to 7577e8d Compare November 12, 2026 09:06
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from efae3db to 6aa9729 Compare November 12, 2026 09:06
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 7577e8d to 2f670b2 Compare November 12, 2026 09:11
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 6aa9729 to f5bf3ea Compare November 12, 2026 09:11
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 2f670b2 to c2d7335 Compare November 12, 2026 09:19
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from f5bf3ea to ac0065e Compare November 12, 2026 09:19
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from c2d7335 to 8c2aca6 Compare November 12, 2026 10:01
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from ac0065e to 2a658e6 Compare November 12, 2026 10:01
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 8c2aca6 to 7a33789 Compare November 12, 2026 10:43
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 2a658e6 to 51b22e3 Compare November 12, 2026 11:02
Comment thread cmd/aitools/install.go
// --skills-only detects agents by config dir alone, as the
// non-interactive run does, so a plugin agent whose CLI is not on
// PATH starts checked too.
preselect: a.IsPreselected(ctx) || (skillsOnly && a.Detected(ctx)),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The comment says that --skills-only pre-checks agents "as the non-interactive run does". But IsPreselected is also true for a plugin agent whose CLI is on PATH and that has no config dir (StateAvailable). The non-interactive --skills-only run selects by config dir only (a.Detected), so it does not pick that agent. Under --skills-only, use preselect = a.Detected(ctx) only, and add a test case for a CLI on PATH with no config dir.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right: the comment overstated it. Under --skills-only the picker pre-checks the union of IsPreselected and Detected, so a plugin agent with its CLI on PATH and no config dir starts checked, while the non-interactive --skills-only run, which selects by config dir only, leaves it out. In c635c52 I reworded the comment to describe what the code does: a config dir also pre-checks the agent under --skills-only, and the usual pre-checks still apply.

The behavior itself is approved on this PR, so I left it as is. Switching to preselect = a.Detected(ctx) under --skills-only, with a test for a CLI on PATH and no config dir, can be a follow-up.

@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 7a33789 to ce44e54 Compare November 12, 2026 12:28
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch 2 times, most recently from a4c1544 to c635c52 Compare November 12, 2026 12:30
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from ce44e54 to 88d00f0 Compare November 12, 2026 12:31
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from c635c52 to b09a485 Compare November 12, 2026 12:31
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 88d00f0 to 14c2f8d Compare November 12, 2026 12:31
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from b09a485 to 2ee6302 Compare November 12, 2026 12:32
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 14c2f8d to 3027224 Compare November 12, 2026 12:34
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 2ee6302 to d105006 Compare November 12, 2026 12:34
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 3027224 to 7586075 Compare November 12, 2026 12:36
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from d105006 to 924919a Compare November 12, 2026 12:36
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 7586075 to 055533b Compare November 12, 2026 12:37
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 924919a to 05df0d0 Compare November 12, 2026 12:37
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 055533b to 22ff761 Compare November 12, 2026 16:38
@anton-107
anton-107 force-pushed the aitools/drop-proceed-confirm branch from 05df0d0 to ea412f5 Compare November 12, 2026 16:38
@anton-107
anton-107 force-pushed the aitools/no-prompts-for-agents branch from 22ff761 to 43056d1 Compare November 12, 2026 17:13
`databricks aitools install` (interactive, no agents on the command line) no longer asks `Proceed?` after the agent picker. Agents that would be skipped are not offered in the picker, so choosing agents already confirms the plan. The install scope moves into the picker title, so it is visible before anything runs, and the plan summary after the picker shrinks to the scope line.

```diff
 install (interactive picker path)
-  promptAgentSelection     # "Select agents to set up", "enter to confirm"
+  promptAgentSelection     # "Select agents to set up (<scope> scope)", "enter to install"
   buildPlan
-  printPlanSummary         # "Plan (<scope> scope):" + one line per agent
-  promptProceed            # "Proceed?" — No => "Cancelled.", exit 0
-    if !proceed: funnel CANCELLED, return nil
   funnel PLAN_CONFIRMED
+  printInstallScope        # "Install scope: <scope>"
   install plugins / skills
```

- `promptProceed` and `defaultPromptProceed` are removed. `promptAgentSelection` takes the scope for its title.
- `printPlanSummary` becomes `printInstallScope`. Its per-agent lines repeated the picker, and its skip branch could no longer run.
- The picker hint reads "space to toggle, enter to install", since Enter now starts the install.
- Under `--skills-only` (and the `databricks skills install` alias), every found agent is labeled "skills" in the picker, skipped rows included, because that is what they get. The removed per-agent summary lines were the only place this showed before. In that mode an agent whose config dir exists also starts checked, so a plugin agent whose CLI is not on PATH is included, as in the non-interactive run.
- `PLAN_CONFIRMED` is kept and still follows `AGENTS_SELECTED` right away; its comment in `libs/telemetry/protos` now says the picker selection is the confirmation.
- `TestInstallFunnelInteractiveCancel` now cancels at the picker, which is the last prompt before the install.
- Changelog fragment: `.nextchanges/cli/aitools-install-drop-proceed-confirm.md`.

Co-authored-by: Isaac <no-reply@databricks.com>
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

❌ Integration test report

Commit: eeb4ef9

Run: 43374700056

Env ❌​FAIL 🟨​KNOWN 💚​RECOVERED ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 39 3 9 1512 1289 176:27
❌​ aws-windows-latest-4core-16gb 41 1 11 1429 1316 201:51
❌​ azure linux-2core-8gb 39 1 11 1492 1297 174:12
❌​ azure-windows-latest-4core-16gb 41 1 11 1409 1324 204:39
❌​ gcp linux-2core-8gb 39 1 11 1499 1295 170:08
❌​ gcp-windows-latest-4core-16gb 39 1 11 1418 1322 213:58
55 interesting tests: 43 FAIL, 9 RECOVERED, 3 KNOWN
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
🟨​ TestAccept 🟨​K 🟨​K 🟨​K 🟨​K 🟨​K 🟨​K
❌​ TestAccept/bundle/invariant/delete_idempotent ✅​p ✅​p ✅​p ❌​F ✅​p ✅​p
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=feature.yml.tmpl/READPLAN=1 ✅​p ✅​p ✅​p ❌​F ✅​p ✅​p
❌​ TestAccept/bundle/invariant/no_drift ✅​p ❌​F ✅​p ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=registered_model.yml.tmpl/READPLAN=1 ✅​p ❌​F ✅​p ✅​p ✅​p ✅​p
💚​ TestAccept/bundle/resources/apps/lifecycle-started 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-toggle 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
❌​ TestAccept/bundle/resources/postgres_branches/update_protected ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_branches/update_protected/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_branches/update_protected/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_branches/update_ttl ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_branches/update_ttl/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_branches/update_ttl/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_databases/update ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_databases/update/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_databases/update/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/remove_suspend_timeout ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/remove_suspend_timeout/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/remove_suspend_timeout/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_autoscaling ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_pg_settings ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_pg_settings/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_pg_settings/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_suspend_timeout ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_suspend_timeout/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_endpoints/update_suspend_timeout/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/add_default_endpoint_settings ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/add_default_endpoint_settings/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/add_default_endpoint_settings/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/remove_history_retention ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/remove_history_retention/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/remove_history_retention/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_default_endpoint_suspend ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_default_endpoint_suspend/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_default_endpoint_suspend/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_display_name ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_display_name/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_display_name/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_history_retention ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_history_retention/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_projects/update_history_retention/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_roles/update ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_roles/update/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/postgres_roles/update/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🟨​ TestAccept/bundle/resources/postgres_synced_tables/recreate 🟨​K 💚​R 💚​R 💚​R 💚​R 💚​R
🟨​ TestAccept/bundle/resources/postgres_synced_tables/recreate/DMS= 🟨​K 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/postgres_synced_tables/recreate/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 50 slowest tests (at least 2 minutes):
duration env testname
13:01 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
11:16 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
10:33 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
9:40 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
9:20 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:16 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:13 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
9:06 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:03 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:00 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
8:55 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
8:25 azure linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
8:19 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:17 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:15 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
8:02 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
7:48 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:37 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
7:23 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
7:23 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
7:14 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
7:06 aws linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
7:03 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:55 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/update-after-create/DMS=true
6:55 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
6:53 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
6:51 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
6:49 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
6:46 aws linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:42 aws linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1
6:42 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
6:41 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:41 aws linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:21 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
6:17 azure linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:15 azure linux-2core-8gb TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=true
6:13 gcp linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:08 gcp linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:07 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
5:56 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=
5:54 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
5:41 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/simple/DMS=
5:31 aws linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=true
5:31 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
5:26 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
5:21 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
5:16 azure linux-2core-8gb TestAccept/pipelines/run/refresh-flags
5:15 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
5:13 aws-windows-latest-4core-16gb TestAccept/bundle/deploy/spark-jar-task/DMS=
5:13 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants