Skip to content

Leave compute_size out of app update mask when not declared - #7461

Merged
andrewnester merged 2 commits into
mainfrom
fix/6400
Nov 11, 2026
Merged

andrewnester merged 2 commits into
mainfrom
fix/6400

Conversation

@andrewnester

Copy link
Copy Markdown
Contributor

Changes

  • UpdateApp builds its update_mask per request via appUpdateMask. compute_size is only named when the request body carries it.
  • Acceptance test resources/apps/update-compute-size covers a declared compute_size (kept in the mask) and its removal (dropped from the mask and body).
  • Golden updates in resources/apps/update and resources/apps/lifecycle-started: the description-only updates no longer name compute_size. The request bodies are unchanged.

Why

The mask was a fixed list, while the SDK field is omitempty. For an undeclared compute_size the body had no key but the mask still named it, which asks the backend to set the field. compute_size is a backend default in configs/apps.yml and the planner skips it, so the update should not touch it either.

compute_min_instances and compute_max_instances are still always in the mask. Nothing in the repo classifies them as backend defaults and the reporter could not test them, so they are unchanged here.

Tests

  • go test ./bundle/direct/...
  • go test ./acceptance -run 'TestAccept/bundle/(resources/apps|apps|invariant|generate/app)'
  • The new acceptance test fails on the previous app.go and passes with this change.
  • golangci-lint on bundle/direct/dresources reports 0 issues.

Fixes #6400

This pull request and its description were written by Isaac.

The app update mask always named compute_size, but the request body omits
it when the bundle does not declare it. The backend applies the named field,
so a deploy silently reset a manually resized app to the default size.
Build the mask per request and drop compute_size when the body does not
carry it.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the DABs DABs related issues label Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: bc44628c5 | Workflow run

Regression test report

Selected 3 changed tests (limit=20, 0 not selected)

6 tests: regression=6 unreleased=0 coverage=0 failing=0
test branch main (7ba9e57) latest (v1.25.0)
TestAccept/bundle/resources/apps/lifecycle-started/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/lifecycle-started/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-compute-size/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-compute-size/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/update/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/update/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/lifecycle-started/DMS=: branch ✅ | main (7ba9e57) ❌ | latest (v1.25.0) ❌

main (7ba9e57):

acceptance_test.go:1345: Diff:
        --- bundle/resources/apps/lifecycle-started/output.txt
        +++ /tmp/TestAcceptbundleresourcesappslifecycle-startedDMS=1774222237/002/output.txt
        @@ -90,7 +90,7 @@
               "description": "MY_APP_DESCRIPTION_2",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
           }
         }
         
        @@ -117,7 +117,7 @@
               "description": "MY_APP_DESCRIPTION_3",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
           }
         }
         {

latest (v1.25.0): same output as main (7ba9e57)

TestAccept/bundle/resources/apps/lifecycle-started/DMS=true: branch ✅ | main (7ba9e57) ❌ | latest (v1.25.0) ❌

main (7ba9e57):

acceptance_test.go:1345: Diff:
        --- bundle/resources/apps/lifecycle-started/output.txt
        +++ /tmp/TestAcceptbundleresourcesappslifecycle-startedDMS=true3574893197/002/output.txt
        @@ -90,7 +90,7 @@
               "description": "MY_APP_DESCRIPTION_2",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
           }
         }
         
        @@ -117,7 +117,7 @@
               "description": "MY_APP_DESCRIPTION_3",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
           }
         }
         {

latest (v1.25.0): same output as main (7ba9e57)

TestAccept/bundle/resources/apps/update-compute-size/DMS=: branch ✅ | main (7ba9e57) ❌ | latest (v1.25.0) ❌

main (7ba9e57):

acceptance_test.go:1345: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1345
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1098
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:660
        	Error:      	Not equal: 
        	            	expected: "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"compute_size\": \"LARGE\",\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"compute_size\": \"LARGE\",\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION_2\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n"
        	            	actual  : "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"compute_size\": \"LARGE\",\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"compute_size\": \"LARGE\",\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION_2\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -32,3 +32,3 @@
        	            	     },
        	            	-    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	+    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	   }
        	Test:       	TestAccept/bundle/resources/apps/update-compute-size/DMS=
        	Messages:   	bundle/resources/apps/update-compute-size/out.requests.json vs /tmp/TestAcceptbundleresourcesappsupdate-compute-sizeDMS=1503564944/001/out.requests.json

latest (v1.25.0): same output as main (7ba9e57)

TestAccept/bundle/resources/apps/update-compute-size/DMS=true: branch ✅ | main (7ba9e57) ❌ | latest (v1.25.0) ❌

main (7ba9e57):

acceptance_test.go:1345: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1345
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1098
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:660
        	Error:      	Not equal: 
        	            	expected: "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"compute_size\": \"LARGE\",\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"compute_size\": \"LARGE\",\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION_2\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n"
        	            	actual  : "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"compute_size\": \"LARGE\",\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"compute_size\": \"LARGE\",\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION_2\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -32,3 +32,3 @@
        	            	     },
        	            	-    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	+    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	   }
        	Test:       	TestAccept/bundle/resources/apps/update-compute-size/DMS=true
        	Messages:   	bundle/resources/apps/update-compute-size/out.requests.json vs /tmp/TestAcceptbundleresourcesappsupdate-compute-sizeDMS=true2569180784/001/out.requests.json

latest (v1.25.0): same output as main (7ba9e57)

TestAccept/bundle/resources/apps/update/DMS=: branch ✅ | main (7ba9e57) ❌ | latest (v1.25.0) ❌

main (7ba9e57):

acceptance_test.go:1345: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1345
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1098
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:660
        	Error:      	Not equal: 
        	            	expected: "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/myappname\"\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"MY_APP_DESCRIPTION\",\n    \"name\": \"mynewappname\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/mynewappname\"\n}\n"
        	            	actual  : "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/myappname\"\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"MY_APP_DESCRIPTION\",\n    \"name\": \"mynewappname\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/mynewappname\"\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -19,3 +19,3 @@
        	            	     },
        	            	-    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	+    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	   }
        	Test:       	TestAccept/bundle/resources/apps/update/DMS=
        	Messages:   	bundle/resources/apps/update/out.requests.json vs /tmp/TestAcceptbundleresourcesappsupdateDMS=2059236573/001/out.requests.json

latest (v1.25.0): same output as main (7ba9e57)

TestAccept/bundle/resources/apps/update/DMS=true: branch ✅ | main (7ba9e57) ❌ | latest (v1.25.0) ❌

main (7ba9e57):

acceptance_test.go:1345: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1345
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1098
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:660
        	Error:      	Not equal: 
        	            	expected: "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/myappname\"\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"MY_APP_DESCRIPTION\",\n    \"name\": \"mynewappname\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/mynewappname\"\n}\n"
        	            	actual  : "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"my_app_description\",\n    \"name\": \"myappname\"\n  }\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/myappname\"\n}\n{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps\",\n  \"q\": {\n    \"no_compute\": \"true\"\n  },\n  \"body\": {\n    \"description\": \"MY_APP_DESCRIPTION\",\n    \"name\": \"mynewappname\"\n  }\n}\n{\n  \"method\": \"DELETE\",\n  \"path\": \"/api/2.0/apps/mynewappname\"\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -19,3 +19,3 @@
        	            	     },
        	            	-    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	+    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
        	            	   }
        	Test:       	TestAccept/bundle/resources/apps/update/DMS=true
        	Messages:   	bundle/resources/apps/update/out.requests.json vs /tmp/TestAcceptbundleresourcesappsupdateDMS=true3623540694/001/out.requests.json
FAIL

latest (v1.25.0): same output as main (7ba9e57)

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: bc44628

Run: 43018502208

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 274 17 12:30
✅​ aws-windows-latest-4core-16gb 276 15 13:24
✅​ azure linux-2core-8gb 273 17 9:58
✅​ azure-windows-latest-4core-16gb 275 15 13:09
✅​ gcp linux-2core-8gb 274 17 8:30
✅​ gcp-windows-latest-4core-16gb 276 15 11:04
Top 15 slowest tests (at least 2 minutes):
duration env testname
10:38 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:50 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:21 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:18 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:24 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:10 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:07 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
7:56 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
7:27 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
7:22 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
6:51 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
6:45 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
3:57 aws-windows-latest-4core-16gb TestAccept
3:45 azure-windows-latest-4core-16gb TestAccept
3:30 gcp-windows-latest-4core-16gb TestAccept

@andrewnester
andrewnester requested review from denik, janniklasrose and pietern and removed request for lennartkats-db November 11, 2026 12:47
})
}
return strings.Join(fields, ",")
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we derive the update mask entirely?

cc @denik

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully: deriving the mask from the request body would stop clearing fields removed from config (all UpdateMaskFields are omitempty, so "in mask, absent from body" is what clears them today), and deriving it from the plan is what #4963 did before #5051 reverted it because the plan can name fields the Update API rejects, so the viable middle ground is the plan-driven mask filtered by the static allowlist, which I'd rather do as a follow-up on top of this and #6399 since it touches the same list.

@andrewnester
andrewnester added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 0d65b03 Nov 11, 2026
28 checks passed
@andrewnester
andrewnester deleted the fix/6400 branch November 11, 2026 14:18
deco-sdk-tagging Bot added a commit that referenced this pull request Nov 11, 2026
## Release v1.26.0

### AI Runtime

 * `air run` reuses its existing workspace connection for config validation instead of opening a second one, which saves a TCP and TLS handshake per submission. ([#7210](#7210))
 * Speed up `databricks air run` for git-pinned `code_source` snapshots by compressing the archive in parallel, which substantially shortens packaging on large repositories. ([#7402](#7402))
 * Point the `air run -h config` agent-skill hint at the stable `databricks-ai-runtime` skill. ([#7454](#7454))

### Bundles

 * Add `DATABRICKS_BUNDLE_INIT_WORKSPACE_HOST_PROFILE`, which names a profile whose host the `workspace_host` template helper returns instead of the selected profile's host. The profile must have the selected profile's workspace ID. ([#7410](#7410))
 * Fixed an explicit `false` on optional boolean fields (`variables.*.sensitive`, `artifacts.*.dynamic_version`, `bundle.deployment.lock.force`, `workspace.azure_use_msi`, `replace_existing` on postgres endpoints, databases and roles, and the `experimental.*` flags) being dropped, which hid it from `bundle validate -o json` and kept a target from overriding `true` with it. ([#7412](#7412))
 * Stop sending `compute_size` in the app update mask when the bundle does not declare it, so a deploy no longer resets a manually resized app to the default size. ([#7461](#7461))
 * `lifecycle.depends_on` can now target the grants or permissions of a resource, as `schemas.foo.grants`. ([#7435](#7435))
 * Add support for the `feature_specs` resource type, including UC grants on a feature spec. ([#7364](#7364))

### Dependency Updates

 * Update the Go SDK to [v0.197.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.197.0). ([#7457](#7457))
 * Bump Go toolchain to 1.27.4. ([#7458](#7458))
andrewnester added a commit that referenced this pull request Nov 11, 2026
The merge of main (#7461) into this branch kept main's header for the old
TestAppRequestBody_StripsSourceCodePathFromForceSendFields on top of this
branch's rewritten body, which no longer compiled (undefined: app). Restore
this branch's TestAppRequestBody_StripsEmptySourceCodePathFromForceSendFields
below main's TestAppUpdateMask_ComputeSizeFollowsBody.

Regenerate the apps acceptance goldens so they reflect both parents:
- update, lifecycle-started: the merge took main's copy, which lacked this
  branch's git_source in the update mask.
- update-compute-size (new on main): add source_code_path to the Create
  body and git_source to the update mask (this branch).
- source-code-path-update (new on this branch): drop compute_size from the
  update mask when the bundle does not declare it (main, #7461).

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UpdateApp masks compute_size unconditionally while omitempty drops it from the body

3 participants