Repository navigation
air: Show full failure reasons and MLflow links in air list panes - #7456
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
…s only for finished runs Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/air/logs-failed-retry: branch ✅ | main (155f0a0) ❌ | latest (v1.26.0) ❌main (155f0a0): latest (v1.26.0): same output as main (155f0a0) |
Collaborator
✅ Integration test reportCommit: 6d6aaa9
Top 25 slowest tests (at least 2 minutes):
|
pardis-beikzadeh-db
requested review from
caroline-db
and removed request for
renaudhartert-db
November 11, 2026 04:14
…ies of the same task The hint named the newest earlier retry, which can be empty too. The MLflow fallback also linked other tasks' runs in multi-task jobs. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
caroline-db
reviewed
Nov 11, 2026
caroline-db
reviewed
Nov 11, 2026
caroline-db
reviewed
Nov 11, 2026
caroline-db
left a comment
Contributor
There was a problem hiding this comment.
The wrapping changes look good. I left a couple of comments about the MLflow retry fallback.
caroline-db
reviewed
Nov 11, 2026
Falling back past a retry whose get-output failed could link an older MLflow run while the newest one is unknown. Co-authored-by: Isaac <no-reply@databricks.com>
…same way in the list The list row linked the first retry's MLflow run while the info and logs panes linked the latest one that has a run. All of them now share one selection, and a link to an older retry says which, for example "(retry 5)". The list cache keeps the task runs this needs, so older cache entries are refreshed. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
caroline-db
approved these changes
Nov 12, 2026
#7491 moved MLflow log links from Artifacts to the Logs page. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
❌ Integration test reportCommit: c7d55d3
80 interesting tests: 68 FAIL, 9 RECOVERED, 3 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air list, the info (i) and logs (L) panes wrap long lines, such asFailure reason:or a log error, instead of cutting them off at the window edge. Box rows and URLs stay on one line, and ←/→ now pans to their ends.air get, the list row and the info and logs panes link the MLflow run from the newest earlier retry of the same task that has one, and name that retry, for example(retry 5). If a newer retry's output can't be fetched, they show no link rather than an older retry's.air logsand the logs pane say earlier retries may have them and give the range of retries to pass to--retry. It gives a range because checking each retry for logs costs several API calls. This also changes the text of the-o jsonERROR line.Known gap: a canceled run still shows no failure reason in
air getor the info pane. This PR doesn't change that.Why
On failed runs, users couldn't read the failure reason in
air list. The panes also showed no MLflow link or logs, even when the list row had a link. The row read MLflow IDs from the first retry, but the panes read them only from the last. Internal ticket: CNXT-2478.Tests
acceptance/air/logs-failed-retry.go test ./cmd/air,go test ./acceptance -run TestAccept/air/,./task checks,./task lint.Manual test
air liston real runs, in a 110-column terminal. w/o fix is this PR's base; w/ fix is this PR. IDs, names and URLs are masked.Info pane (
i), long failure reason:Logs pane (
L), same run (excerpt):Info pane, run whose last retry has no MLflow output or logs:
air listMLflow column, same run (w/o fix links retry 0, w/ fix retry 5):Logs pane and
air logs, same run:Same stuff but in screenshots:
This pull request and its description were written by Isaac.