Repository navigation
Discourage package-level regexp and reflect work in Go style guide - #7448
Merged
Merged
Conversation
Package-level initializers run on every CLI invocation, so agents should defer such work with sync.OnceValue. The rule lives next to the existing sync.OnceValue guidance in the Go style guide, which is loaded for Go files only. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: d65faae
Top 3 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 11, 2026
Collaborator
❌ Integration test reportCommit: 3840d67
8 interesting tests: 4 FAIL, 4 flaky
Top 50 slowest tests (at least 2 minutes):
|
tedjt
pushed a commit
to tedjt/cli
that referenced
this pull request
Nov 12, 2026
…7484) ## Changes Follow-up to databricks#7483. `testmask` now ignores agent config (`.agents/`, `.claude/`, `.cursor/`, `AGENTS.md`), root docs (`README.md`, `CHANGELOG.md`, `SECURITY.md`), GitHub issue/PR templates, and `.nextchanges` fragments. Ignored entries support `path.Match` globs and a trailing `/**` for directories. ## Why PRs touching only these files (e.g. databricks#7464, databricks#7448, databricks#7344) still ran the full test matrix. Nested READMEs are left out since many are acceptance outputs or embedded templates. ## Tests Added unit cases, and testmask returns `[]` for the PRs above. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rule to the Go style guide: wrap regexps and reflection in
sync.OnceValueinstead of running them at package level, and make sure a test calls the wrapped value. This keeps agents from reintroducing what the PRs below this one removed.This pull request and its description were written by Isaac.