Skip to content

Compile dynvar reference regexp on first use - #7447

Merged
pietern merged 1 commit into
init-time-structpathfrom
init-time-dynvar
Nov 11, 2026
Merged

pietern merged 1 commit into
init-time-structpathfrom
init-time-dynvar

Conversation

@pietern

@pietern pietern commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Same fix for the ${...} regexp in dynvar, which uses the same grammar as structpath: 0.20 ms on every invocation.

Tests: existing tests run the initializer.

This pull request and its description were written by Isaac.

Like structpath's, the reference regexp uses Unicode letter/number
classes that are expensive to compile, and it was compiled on every CLI
invocation. Wrap it in sync.OnceValue.

Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern added this pull request to stack #7449 November 10, 2026 15:46
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 935a5de

Run: 42848315544

Env 🔄​flaky ✅​pass 🙈​skip Time
🔄​ aws linux-2core-8gb 2 269 15 7:44
✅​ aws-windows-latest-4core-16gb 273 13 5:04
✅​ azure linux-2core-8gb 270 15 8:09
✅​ azure-windows-latest-4core-16gb 272 13 3:59
✅​ gcp linux-2core-8gb 271 15 9:56
✅​ gcp-windows-latest-4core-16gb 273 13 5:15
Test Name aws linux-2core-8gb
🔄​ TestFilerRecursiveDelete 🔄​f
🔄​ TestFilerRecursiveDelete/files 🔄​f
Top 4 slowest tests (at least 2 minutes):
duration env testname
3:29 azure-windows-latest-4core-16gb TestAccept
3:22 gcp-windows-latest-4core-16gb TestAccept
3:22 aws-windows-latest-4core-16gb TestAccept
2:24 gcp linux-2core-8gb TestTelemetryEndpoint

@pietern
pietern marked this pull request as ready for review November 11, 2026 07:50
@pietern
pietern requested a review from a team as a code owner November 11, 2026 07:50
@pietern
pietern requested a review from andrewnester November 11, 2026 07:50
@pietern
pietern added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit f795adb Nov 11, 2026
25 checks passed
@pietern
pietern deleted the init-time-dynvar branch November 11, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants