Skip to content

Compile structpath reference regexp on first use - #7446

Merged
pietern merged 1 commit into
init-time-resources-typesfrom
init-time-structpath
Nov 11, 2026
Merged

pietern merged 1 commit into
init-time-resources-typesfrom
init-time-structpath

Conversation

@pietern

@pietern pietern commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Wraps pureReference in sync.OnceValue. Its \p{L}/\p{N} classes make it expensive to compile: 0.35 ms on every invocation.

Tests: existing tests run the initializer.

This pull request and its description were written by Isaac.

The Unicode letter/number classes in pureReference make it expensive to
compile (~0.3 ms), and it was compiled on every CLI invocation. Wrap it
in sync.OnceValue.

Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern added this pull request to stack #7449 November 10, 2026 15:46
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: a949652

Run: 42848247613

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 271 15 7:46
✅​ aws-windows-latest-4core-16gb 273 13 5:07
✅​ azure linux-2core-8gb 270 15 7:47
✅​ azure-windows-latest-4core-16gb 272 13 4:27
✅​ gcp linux-2core-8gb 271 15 8:03
✅​ gcp-windows-latest-4core-16gb 273 13 5:05
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:18 gcp-windows-latest-4core-16gb TestAccept
3:11 azure-windows-latest-4core-16gb TestAccept
2:45 aws-windows-latest-4core-16gb TestAccept

@pietern
pietern marked this pull request as ready for review November 11, 2026 07:50
@pietern
pietern requested a review from a team as a code owner November 11, 2026 07:50
@pietern
pietern added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 6861c59 Nov 11, 2026
25 checks passed
@pietern
pietern deleted the init-time-structpath branch November 11, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants