Repository navigation
Build bundle/config.ResourcesTypes on first use - #7445
Merged
Merged
Conversation
ResourcesTypes walked every resource type with reflection at package init, on every CLI invocation. Make it a sync.OnceValue; its only non-test caller is Root.GetResourceConfig. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 0217742
Top 3 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourcesTypesis now async.OnceValueinstead of a map built at init. Building it walks every resource type with reflection, which took 0.36 ms on every invocation.Tests: existing tests run the initializer.
This pull request and its description were written by Isaac.