Repository navigation
Compile cmd/air regexps on first use - #7444
Merged
Merged
Conversation
The 32 package-level regexps in cmd/air were compiled on every CLI invocation (~1 ms of init time on CI), even though they are only used by air subcommands. Wrap them in sync.OnceValue. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 58b177a
Top 4 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the 32 package-level regexps in
cmd/airinsync.OnceValue. They took 1.2 ms of init time on every CLI invocation (Linux CI), but onlyairsubcommands use them.Tests: existing tests run all 12 initializers.
This pull request and its description were written by Isaac.