Repository navigation
Record deployment history for bundle resource unbindings - #7401
Draft
shreyas-goenka wants to merge 7 commits into
Draft
shreyas-goenka wants to merge 7 commits into
shreyas-goenka wants to merge 7 commits into
Conversation
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-unbind-history
branch
from
November 9, 2026 08:01
6247b4f to
1ea379e
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-bind-history
branch
from
November 9, 2026 08:08
938294b to
2c7cf79
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-unbind-history
branch
from
November 9, 2026 08:08
1ea379e to
d74b071
Compare
Collaborator
✅ Integration test reportCommit: 3befeec
6 interesting tests: 6 flaky
Top 13 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-unbind-history
branch
from
November 9, 2026 09:21
d74b071 to
f75d31f
Compare
Contributor
|
Commit: Regression test reportSelected 7 changed tests (limit=20, 0 not selected) 12 tests: regression=4 unreleased=0 coverage=8 failing=0
TestAccept/bundle/dms/bind-history-failures/DMS=true: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): same output as main (46546d1) TestAccept/bundle/dms/bind-immutable/DMS=true: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): same output as main (46546d1) TestAccept/bundle/dms/bind-unbind/DMS=true: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): TestAccept/bundle/dms/unbind-history-failures/DMS=true: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): |
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-unbind-history
branch
20 times, most recently
from
November 10, 2026 12:10
2017d94 to
6f52001
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-bind-history
branch
from
November 13, 2026 12:58
445c82f to
7b569b3
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-unbind-history
branch
from
November 13, 2026 12:59
6f52001 to
3befeec
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Record
bundle deployment unbindasUPDATEoperations for the resource and each removed child state entry. Clear their recorded state, skip history versions when no binding was removed, and leave workspace resources intact.Reuse the shared DMS operation buffer and bind's version creation/completion helpers. Recording remains best effort. StateDB persistence is unchanged: there is no extra state write or serial increment to publish history. Complete the version after remote state upload, marking it failed when upload or history recording fails.
Direct StateDB integration would require reorganizing binding preparation and commit. The shared buffer provides the same recording mechanism with the smaller change.
Stacked on #7400.
Tests
This PR was written by Codex.