Repository navigation
[draft] Add bundle deploy --exclude resource selector - #7348
Open
lennartkats-db wants to merge 6 commits into
Open
lennartkats-db wants to merge 6 commits into
lennartkats-db wants to merge 6 commits into
Conversation
lennartkats-db
requested review from
Sankalp-Mittal
and removed request for
Sankalp-Mittal and
rclarey
November 4, 2026 15:19
Contributor
|
Commit: Regression test reportSelected 3 changed tests (limit=20, 0 not selected) 8 tests: regression=8 unreleased=0 coverage=0 failing=0
TestAccept/bundle/help/bundle-deploy/DMS=: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/help/bundle-deploy/DMS=true: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/select/exclude_basic/DMS=/READPLAN=: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/select/exclude_basic/DMS=/READPLAN=1: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/select/exclude_basic/DMS=true/READPLAN=: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/select/exclude_basic/DMS=true/READPLAN=1: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/select/exclude_immutable_snapshot/DMS=: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) TestAccept/bundle/select/exclude_immutable_snapshot/DMS=true: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): same output as main (8e70c8b) |
Collaborator
✅ Integration test reportCommit: 8895de6
Top 12 slowest tests (at least 2 minutes):
|
…xclude-6978 # Conflicts: # bundle/direct/bundle_plan.go
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--excludetobundle deployandbundle planso a direct-engine plan can omit named resources and their grants and permissions. Repeated selectors deduplicate; unknown or ambiguous names fail.lifecycle.depends_onedges do not hold an ID reference.--excludewith--selector when applying a saved--plan. A filtered plan can instead be generated withbundle plan --excludeand applied later.Why
Deploying prerequisites before a small set of resources currently requires maintaining a growing
--selectlist. Exclusion lets the first stage track new resources automatically while the dependency checks keep the partial plan safe.Fixes #6978
Tests
go test ./bundle/deployplan ./bundle/direct ./bundle/phases ./cmd/bundle/...go test ./acceptance -run 'TestAccept/bundle/select/exclude_basic' -count=1 -v(direct and DMS, fresh and saved plans)go test ./acceptance -run 'TestAccept/bundle/select/exclude_immutable_snapshot' -count=1 -v(direct and DMS, excluded job keeps its old snapshot path)go test ./acceptance -run 'TestAccept/bundle/deploy/immutable/select' -count=1 -vgo test ./acceptance -run 'TestAccept/bundle/help/bundle-deploy' -count=1 -v./task checksThis PR was written by Codex.