Repository navigation
acc: Replace find with find.py - #6714
Merged
Merged
Conversation
Contributor
Approval status: pending
|
Collaborator
✅ Integration test reportCommit: a2e0424
Top 6 slowest tests (at least 2 minutes):
|
denik
reviewed
Sep 16, 2026
Main restructured acceptance/bundle/migrate and converted those tests to find.py itself, so the migrate changes from this branch are dropped in favor of main's versions. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 3 changed tests (limit=20, 0 not selected) 6 tests: regression=0 unreleased=0 coverage=6 failing=0
|
The destroy tests pruned .databricks/bundle/default/terraform to keep engine-specific provider files out of the golden. Since the terraform engine removal nothing in these tests creates that directory, so the flag matched nothing and had no other caller. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
enabled auto-merge
November 11, 2026 14:16
This was referenced Nov 11, 2026
andrewnester
approved these changes
Nov 11, 2026
andrewnester
left a comment
Contributor
There was a problem hiding this comment.
Optional: .agents/rules/testing.md line 180 still lists the helper as find.py REGEX [--expect N]; worth adding [--dirs] there so the helper list stays in step with the script.
Collaborator
❌ Integration test reportCommit: 770c7dc
384 interesting tests: 357 MISS, 27 FAIL
Top 50 slowest tests (at least 2 minutes):
|
tedjt
pushed a commit
to tedjt/cli
that referenced
this pull request
Nov 12, 2026
…abricks#7464) ## Changes Pass 8 of the pr-review skill listed new doc comments with a Go-only grep. This widens the pass to Python, shell and YAML (the languages `.agents/rules/comments.md` covers), counts `acceptance/bin/*.py` docstrings and `--help` text and the doc comment of a new test function in test-only changes, and asks the reviewer to check the other callers of an API when a new comment claims a quirk of it. ## Why In reviews of databricks#7187, databricks#7462, databricks#6923, databricks#3518, databricks#6714 and databricks#7184 the pass produced an empty table on exactly the changes where the comment was the main thing to judge: a YAML labeler config, a Python-only comment block, a test-only invariant test, a shared acceptance helper. The findings on those PRs came from reading `comments.md` by hand instead. On databricks#7184 a new comment asserted an API rejection that another caller of the same endpoint contradicts. ## Tests Documentation only, no code changes. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the remaining shell
findinvocations in acceptance scripts with thefind.pyhelper, so file listings are sorted and forward-slashed independently of the platform'sfind/sort.find.pygains one opt-in flag,--dirs, which matches and prints directories too (default stays files only). The destroy tests need it to print the whole.databrickstree so that an empty scaffolding directory left behind by destroy shows up.Converted call sites:
bundle/destroy/jobs-and-pipeline,bundle/destroy/lineage-mismatch-after-redeploy:find .databricks -name terraform -prune -o -print | sort→find.py --dirs '^\.databricks(/|$)'. The-pruneof the terraform dir is dropped: since the terraform engine removal nothing in these tests creates that directory.bundle/generate/job_nested_notebooks:find src -type f | sort→find.py '^src/'Output lines are unchanged; only the
>>>echo lines in the goldens differ.Left as shell
find:bundle/templates/pydabs/init-classicusesfind ... -deleteto prune the materialized template before snapshotting;find.pyis a read-only lister.The migrate-test conversions originally in this branch were dropped after merging main, which restructured
acceptance/bundle/migrate/and converted those tests tofind.pyitself.This pull request and its description were written by Isaac.