Skip to content

acc: Replace find with find.py - #6714

Merged
janniklasrose merged 5 commits into
mainfrom
janniklasrose/use-find.py
Nov 11, 2026
Merged

janniklasrose merged 5 commits into
mainfrom
janniklasrose/use-find.py

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Replaces the remaining shell find invocations in acceptance scripts with the find.py helper, so file listings are sorted and forward-slashed independently of the platform's find/sort.

find.py gains one opt-in flag, --dirs, which matches and prints directories too (default stays files only). The destroy tests need it to print the whole .databricks tree so that an empty scaffolding directory left behind by destroy shows up.

Converted call sites:

  • bundle/destroy/jobs-and-pipeline, bundle/destroy/lineage-mismatch-after-redeploy: find .databricks -name terraform -prune -o -print | sort → find.py --dirs '^\.databricks(/|$)'. The -prune of the terraform dir is dropped: since the terraform engine removal nothing in these tests creates that directory.
  • bundle/generate/job_nested_notebooks: find src -type f | sort → find.py '^src/'

Output lines are unchanged; only the >>> echo lines in the goldens differ.

Left as shell find: bundle/templates/pydabs/init-classic uses find ... -delete to prune the materialized template before snapshotting; find.py is a read-only lister.

The migrate-test conversions originally in this branch were dropped after merging main, which restructured acceptance/bundle/migrate/ and converted those tests to find.py itself.

This pull request and its description were written by Isaac.

@janniklasrose
janniklasrose requested a review from denik September 16, 2026 15:39
@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

19 files changed
Suggested: @denik
Also eligible: @shreyas-goenka, @pietern, @andrewnester, @anton-107, @lennartkats-db

General files (require maintainer)

Files: acceptance/bin/find.py
Based on git history:

  • @denik -- recent work in acceptance/bundle/migrate/auto-migrate-plan-failure/, acceptance/bundle/migrate/auto-migrate-default/, acceptance/bundle/migrate/auto-migrate-clean/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: a2e0424

Run: 43036296790

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 274 17 6:23
✅​ aws-windows-latest-4core-16gb 276 15 4:08
✅​ azure linux-2core-8gb 273 17 5:38
✅​ azure-windows-latest-4core-16gb 275 15 4:38
✅​ gcp linux-2core-8gb 274 17 6:20
✅​ gcp-windows-latest-4core-16gb 276 15 4:18
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:04 azure linux-2core-8gb TestAccept
4:03 gcp linux-2core-8gb TestAccept
3:59 aws linux-2core-8gb TestAccept
3:59 azure-windows-latest-4core-16gb TestAccept
3:39 gcp-windows-latest-4core-16gb TestAccept
3:28 aws-windows-latest-4core-16gb TestAccept

Comment thread acceptance/bin/find.py Resolved
janniklasrose and others added 2 commits November 9, 2026 23:24
Main restructured acceptance/bundle/migrate and converted those tests to
find.py itself, so the migrate changes from this branch are dropped in favor
of main's versions.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@janniklasrose
janniklasrose requested review from a team as code owners November 9, 2026 23:32
@github-actions github-actions Bot added the DABs DABs related issues label Nov 9, 2026
@janniklasrose
janniklasrose requested a review from denik November 9, 2026 23:33
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Commit: a2e04242d | Workflow run

Regression test report

Selected 3 changed tests (limit=20, 0 not selected)

6 tests: regression=0 unreleased=0 coverage=6 failing=0
test branch main (e6045a1) latest (v1.25.0)
TestAccept/bundle/destroy/jobs-and-pipeline/DMS= ✅ ✅ ✅
TestAccept/bundle/destroy/jobs-and-pipeline/DMS=true ✅ ✅ ✅
TestAccept/bundle/destroy/lineage-mismatch-after-redeploy/DMS= ✅ ✅ ✅
TestAccept/bundle/destroy/lineage-mismatch-after-redeploy/DMS=true ✅ ✅ ✅
TestAccept/bundle/generate/job_nested_notebooks/DMS= ✅ ✅ ✅
TestAccept/bundle/generate/job_nested_notebooks/DMS=true ✅ ✅ ✅

Comment thread acceptance/bin/find.py Resolved
The destroy tests pruned .databricks/bundle/default/terraform to keep
engine-specific provider files out of the golden. Since the terraform
engine removal nothing in these tests creates that directory, so the
flag matched nothing and had no other caller.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the test-only-fix PRs that update failing of flaky tests without changing CLI code. label Nov 11, 2026

@andrewnester andrewnester left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: .agents/rules/testing.md line 180 still lists the helper as find.py REGEX [--expect N]; worth adding [--dirs] there so the helper list stays in step with the script.

@janniklasrose
janniklasrose added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 770c7dc Nov 11, 2026
27 checks passed
@janniklasrose
janniklasrose deleted the janniklasrose/use-find.py branch November 11, 2026 14:43
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

❌ Integration test report

Commit: 770c7dc

Run: 43041373006

Env ❌​FAIL 🤯​MISS ✅​pass 🙈​skip Time
❌​ gcp-windows-latest-4core-16gb 27 357 1037 1307 345:42
384 interesting tests: 357 MISS, 27 FAIL
Test Name gcp-windows-latest-4core-16gb
🤯​ TestAccept 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions/DMS= 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions/DMS=true 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS= 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS=true 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS= 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS=true 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info/DMS= 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info/DMS=true 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=/DMS=true 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=true/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=true/DMS=true 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync/DMS=true 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/basic 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/basic/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/breakglass 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/breakglass/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/can-manage 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/can-manage/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/destroy-redeploy 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/destroy-redeploy/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/dev-mode 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/dev-mode/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/legacy-state 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/legacy-state/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/missing-snapshot 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/missing-snapshot/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/permissions-change 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/permissions-change/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/select 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/select/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks/DMS=true 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task/DMS= 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task/DMS=true 🤯​M
🤯​ TestAccept/bundle/deployment/bind/alert 🤯​M
🤯​ TestAccept/bundle/deployment/bind/alert/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/bind/alert/DMS=true 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog/DMS=true 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster/DMS=true 🤯​M
❌​ TestAccept/bundle/deployment/bind/dashboard ❌​F
❌​ TestAccept/bundle/deployment/bind/dashboard/DMS=true/READPLAN= ❌​F
🤯​ TestAccept/bundle/deployment/bind/vector_search_endpoint 🤯​M
🤯​ TestAccept/bundle/deployment/bind/vector_search_endpoint/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/bind/vector_search_endpoint/DMS=true 🤯​M
🤯​ TestAccept/bundle/deployment/bind/volume 🤯​M
🤯​ TestAccept/bundle/deployment/bind/volume/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/bind/volume/DMS=true 🤯​M
🤯​ TestAccept/bundle/deployment/unbind/grants 🤯​M
🤯​ TestAccept/bundle/deployment/unbind/grants/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/unbind/grants/DMS=true 🤯​M
🤯​ TestAccept/bundle/deployment/unbind/permissions 🤯​M
🤯​ TestAccept/bundle/deployment/unbind/permissions/DMS= 🤯​M
🤯​ TestAccept/bundle/deployment/unbind/permissions/DMS=true 🤯​M
🤯​ TestAccept/bundle/destroy/jobs-and-pipeline 🤯​M
🤯​ TestAccept/bundle/destroy/jobs-and-pipeline/DMS= 🤯​M
🤯​ TestAccept/bundle/destroy/jobs-and-pipeline/DMS=true 🤯​M
🤯​ TestAccept/bundle/destroy/root-path-name-target 🤯​M
🤯​ TestAccept/bundle/destroy/root-path-name-target/DMS= 🤯​M
🤯​ TestAccept/bundle/destroy/root-path-name-target/DMS=true 🤯​M
🤯​ TestAccept/bundle/destroy/root-path-not-scoped 🤯​M
🤯​ TestAccept/bundle/destroy/root-path-not-scoped/DMS= 🤯​M
🤯​ TestAccept/bundle/destroy/root-path-not-scoped/DMS=true 🤯​M
🤯​ TestAccept/bundle/destroy/sibling-target 🤯​M
🤯​ TestAccept/bundle/destroy/sibling-target/DMS= 🤯​M
🤯​ TestAccept/bundle/destroy/sibling-target/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/declined-deploy 🤯​M
🤯​ TestAccept/bundle/dms/declined-deploy/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/depends-on 🤯​M
🤯​ TestAccept/bundle/dms/depends-on/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/deployment-metadata-change 🤯​M
🤯​ TestAccept/bundle/dms/deployment-metadata-change/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/existing-state 🤯​M
🤯​ TestAccept/bundle/dms/existing-state/DMS= 🤯​M
🤯​ TestAccept/bundle/dms/multiple-resources 🤯​M
🤯​ TestAccept/bundle/dms/multiple-resources/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/no-drift 🤯​M
🤯​ TestAccept/bundle/dms/no-drift/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/no-resources 🤯​M
🤯​ TestAccept/bundle/dms/no-resources/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/provenance 🤯​M
🤯​ TestAccept/bundle/dms/provenance/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/record-failure 🤯​M
🤯​ TestAccept/bundle/dms/record-failure/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/stale-local-state 🤯​M
🤯​ TestAccept/bundle/dms/stale-local-state/DMS= 🤯​M
🤯​ TestAccept/bundle/dms/stale-plan 🤯​M
🤯​ TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN= 🤯​M
🤯​ TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/dms/state-features 🤯​M
🤯​ TestAccept/bundle/dms/state-features/DMS=true 🤯​M
🤯​ TestAccept/bundle/dms/successful-recreate 🤯​M
🤯​ TestAccept/bundle/dms/successful-recreate/DMS=true 🤯​M
🤯​ TestAccept/bundle/generate/alert 🤯​M
🤯​ TestAccept/bundle/generate/alert/DMS= 🤯​M
🤯​ TestAccept/bundle/generate/alert/DMS=true 🤯​M
🤯​ TestAccept/bundle/generate/auto-bind 🤯​M
🤯​ TestAccept/bundle/generate/auto-bind/DMS= 🤯​M
🤯​ TestAccept/bundle/generate/auto-bind/DMS=true 🤯​M
🤯​ TestAccept/bundle/generate/pipeline_and_deploy 🤯​M
🤯​ TestAccept/bundle/generate/pipeline_and_deploy/DMS= 🤯​M
🤯​ TestAccept/bundle/generate/pipeline_and_deploy/DMS=true 🤯​M
🤯​ TestAccept/bundle/generate/python_job_and_deploy 🤯​M
🤯​ TestAccept/bundle/generate/python_job_and_deploy/DMS= 🤯​M
🤯​ TestAccept/bundle/generate/python_job_and_deploy/DMS=true 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=app.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=catalog.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=cluster.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=dashboard.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=experiment.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=feature.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_apply_policy_default_values_for_each_task.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_apply_policy_default_values_job_cluster.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_apply_policy_default_values_task_cluster.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_pydabs_10_tasks.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_table_update_trigger.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_with_depends_on.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_with_task.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=model.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=model_serving_endpoint.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=pipeline.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=pipeline_allow_duplicate_names.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=pipeline_apply_policy_default_values.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=registered_model.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=schema.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=schema_empty_grants.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=schema_tf_compat.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=schema_uppercase_name.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=secret_scope.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=secret_scope_default_backend_type.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=sql_warehouse.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=volume.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=volume_uppercase_name.yml.tmpl 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=app.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=catalog.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=catalog.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_policy.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_policy.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=dashboard.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=dashboard.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=experiment.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=experiment.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=feature.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=feature.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=genie_space.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=genie_space.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=instance_pool.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=instance_pool.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_apply_policy_default_values_for_each_task.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_apply_policy_default_values_for_each_task.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_apply_policy_default_values_job_cluster.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_apply_policy_default_values_job_cluster.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_apply_policy_default_values_task_cluster.yml.tmpl/READPLAN= 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_apply_policy_default_values_task_cluster.yml.tmpl/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_pydabs_10_tasks.yml.tmpl/READPLAN=1 🤯​M
❌​ TestAccept/bundle/resources/alerts/basic ❌​F
❌​ TestAccept/bundle/resources/alerts/basic/DMS= ❌​F
❌​ TestAccept/bundle/resources/alerts/basic/DMS=true ❌​F
❌​ TestAccept/bundle/resources/apps/lifecycle-started-toggle ❌​F
❌​ TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=true ❌​F
❌​ TestAccept/bundle/resources/catalogs/comment_out_of_band ❌​F
❌​ TestAccept/bundle/resources/catalogs/comment_out_of_band/DMS=true ❌​F
❌​ TestAccept/bundle/resources/cluster_policies/basic ❌​F
❌​ TestAccept/bundle/resources/cluster_policies/basic/DMS=true ❌​F
🤯​ TestAccept/bundle/resources/clusters/deploy/local_ssd_count 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/simple 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/simple/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/simple/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/update-after-create 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/update-after-create/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/clusters/deploy/update-after-create/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/clusters/lifecycle-started 🤯​M
🤯​ TestAccept/bundle/resources/clusters/lifecycle-started-toggle 🤯​M
🤯​ TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/clusters/lifecycle-started/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/clusters/resize-terminated-fallback 🤯​M
🤯​ TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-embed-credentials 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-embed-credentials/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-embed-credentials/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-name 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-name/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-name/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-parent-path 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-parent-path/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-parent-path/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-serialized-dashboard 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-serialized-dashboard/DMS=/READPLAN= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-serialized-dashboard/DMS=/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-serialized-dashboard/DMS=true/READPLAN= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/change-serialized-dashboard/DMS=true/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/dataset-catalog-schema 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/dataset-catalog-schema/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/dataset-catalog-schema/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/delete-trashed-out-of-band 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/delete-trashed-out-of-band/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/delete-trashed-out-of-band/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/destroy 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/destroy/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/destroy/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/detect-change 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/detect-change/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/detect-change/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/generate_inplace 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/generate_inplace/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/generate_inplace/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/nested-folders 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/nested-folders/DMS=/READPLAN= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/nested-folders/DMS=/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/nested-folders/DMS=true/READPLAN= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/nested-folders/DMS=true/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/serialized-inline 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/serialized-inline/DMS=/READPLAN= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/serialized-inline/DMS=/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/serialized-inline/DMS=true/READPLAN= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/serialized-inline/DMS=true/READPLAN=1 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple_outside_bundle_root 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple_outside_bundle_root/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple_outside_bundle_root/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple_syncroot 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple_syncroot/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/simple_syncroot/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/unpublish-out-of-band 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/unpublish-out-of-band/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/dashboards/unpublish-out-of-band/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/data_quality_monitors/lifecycle 🤯​M
🤯​ TestAccept/bundle/resources/data_quality_monitors/lifecycle/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/data_quality_monitors/lifecycle/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/experiments/basic 🤯​M
🤯​ TestAccept/bundle/resources/experiments/basic/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/experiments/basic/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/features/lifecycle 🤯​M
🤯​ TestAccept/bundle/resources/features/lifecycle/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/change-serialized-space 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/change-serialized-space/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/change-serialized-space/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/parent_path_update 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/parent_path_update/DMS= 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/parent_path_update/DMS=true 🤯​M
🤯​ TestAccept/bundle/resources/genie_spaces/recreate_when_gone 🤯​M
Top 50 slowest tests (at least 2 minutes):
duration env testname
16:12 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
13:32 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:35 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=job_run.yml.tmpl/READPLAN=
8:53 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1
7:57 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/materialization_sets/batch/DMS=
7:38 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=model_with_permissions.yml.tmpl/READPLAN=
7:35 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_empty_grants.yml.tmpl/READPLAN=
7:31 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
7:11 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
6:36 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/registered_models/basic/DMS=
6:30 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=model_with_permissions.yml.tmpl/READPLAN=1
6:15 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=vector_search_endpoint.yml.tmpl/READPLAN=1
6:13 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
6:03 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_uppercase_name.yml.tmpl/READPLAN=
5:54 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=secret.yml.tmpl/READPLAN=1
5:53 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=sql_warehouse.yml.tmpl/READPLAN=
5:49 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_with_task.yml.tmpl/READPLAN=1
5:47 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/registered_models/basic/DMS=true
5:41 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_cross_resource_ref.yml.tmpl/READPLAN=1
5:39 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=model.yml.tmpl/READPLAN=
5:31 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=volume_path_job_ref.yml.tmpl/READPLAN=1
5:24 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_empty_grants.yml.tmpl/READPLAN=1
5:22 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=true
5:16 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=job_apply_policy_default_values_task_cluster.yml.tmpl/READPLAN=1
5:13 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
5:08 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=model.yml.tmpl/READPLAN=1
5:07 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_grant_ref.yml.tmpl/READPLAN=1
5:00 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=feature.yml.tmpl/READPLAN=
4:59 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=pipeline_config_dots.yml.tmpl/READPLAN=
4:58 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=app.yml.tmpl/READPLAN=
4:57 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=app.yml.tmpl/READPLAN=
4:56 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=pipeline_apply_policy_default_values.yml.tmpl/READPLAN=
4:55 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_with_depends_on.yml.tmpl/READPLAN=1
4:54 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_permission_ref.yml.tmpl/READPLAN=1
4:53 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_run.yml.tmpl/READPLAN=
4:52 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=vector_search_index.yml.tmpl/READPLAN=1
4:51 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=
4:51 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=secret_scope_default_backend_type.yml.tmpl/READPLAN=1
4:47 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=vector_search_endpoint.yml.tmpl/READPLAN=
4:42 gcp-windows-latest-4core-16gb TestAccept/cmd/fs/cp/file-to-nonexistent-dir
4:40 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
4:39 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_run.yml.tmpl/READPLAN=1
4:37 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=volume_path_job_ref.yml.tmpl/READPLAN=1
4:35 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_tf_compat.yml.tmpl/READPLAN=
4:34 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=vector_search_index.yml.tmpl/READPLAN=
4:32 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=sql_warehouse.yml.tmpl/READPLAN=1
4:31 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=experiment.yml.tmpl/READPLAN=1
4:30 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=pipeline.yml.tmpl/READPLAN=1
4:29 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=secret_scope.yml.tmpl/READPLAN=
4:20 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=job_with_depends_on.yml.tmpl/READPLAN=
(107 table rows omitted to keep the report under 60000 bytes)

tedjt pushed a commit to tedjt/cli that referenced this pull request Nov 12, 2026
…abricks#7464)

## Changes
Pass 8 of the pr-review skill listed new doc comments with a Go-only
grep. This widens the pass to Python, shell and YAML (the languages
`.agents/rules/comments.md` covers), counts `acceptance/bin/*.py`
docstrings and `--help` text and the doc comment of a new test function
in test-only changes, and asks the reviewer to check the other callers
of an API when a new comment claims a quirk of it.

## Why
In reviews of databricks#7187, databricks#7462, databricks#6923, databricks#3518, databricks#6714 and databricks#7184 the pass
produced an empty table on exactly the changes where the comment was the
main thing to judge: a YAML labeler config, a Python-only comment block,
a test-only invariant test, a shared acceptance helper. The findings on
those PRs came from reading `comments.md` by hand instead. On databricks#7184 a
new comment asserted an API rejection that another caller of the same
endpoint contradicts.

## Tests
Documentation only, no code changes.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants