ENH: add nanmean - #910
Open
ushnah wants to merge 2 commits into
Open
Conversation
Member
|
cc @OmarManzoor |
qbarthelemy
reviewed
Aug 19, 2026
qbarthelemy
left a comment
qbarthelemy
left a comment
Contributor
There was a problem hiding this comment.
Branch must be rebased, because code has been moved to src\array_api_extra\_agnostic\_statistical.py
Comment on lines
+887
to
+888
| zero = xp.asarray(0, dtype=a.dtype, device=device_a) | ||
| sum_ = xp.sum(xp.where(mask, zero, a), axis=axis) |
Contributor
There was a problem hiding this comment.
We could simply use nansum:
Suggested change
| zero = xp.asarray(0, dtype=a.dtype, device=device_a) | |
| sum_ = xp.sum(xp.where(mask, zero, a), axis=axis) | |
| sum_ = nansum(a, axis=axis, xp=xp) |
| sum_ = xp.sum(xp.where(mask, zero, a), axis=axis) | ||
| count = xp.count_nonzero(~mask, axis=axis) | ||
| safe_count = xp.astype( | ||
| xp.where(count == 0, xp.asarray(1, dtype=count.dtype, device=device_a), count), |
Contributor
There was a problem hiding this comment.
Suggested change
| xp.where(count == 0, xp.asarray(1, dtype=count.dtype, device=device_a), count), | |
| xp.where(count == 0, xp.ones_like(a), count), |
| if xp.any(count == 0): | ||
| result = xp.where( | ||
| count == 0, | ||
| xp.asarray(xp.nan, dtype=result.dtype, device=device_a), |
Contributor
There was a problem hiding this comment.
Suggested change
| xp.asarray(xp.nan, dtype=result.dtype, device=device_a), | |
| xp.full_like(result, xp.nan), |
With these three modifications, device_a is no longer necessary in nanmean.
ushnah
force-pushed
the
nanmean
branch
3 times, most recently
from
August 23, 2026 22:46
4eaf451 to
1ba49d5
Compare
OmarManzoor
reviewed
Aug 24, 2026
qbarthelemy
approved these changes
Aug 24, 2026
applying changes for mean Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
OmarManzoor
approved these changes
Aug 25, 2026
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @ushnah
Contributor
|
CC: @lucascolley I think this looks fine to merge |
lucascolley
self-requested a review
August 25, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #789