More tiling checks - #22145
Merged
TurboGit merged 2 commits intoSep 4, 2026
Merged
Conversation
We may not tile if the piece->tiling ready flag is not TRUE. (This requires the module->flags including IOP_FLAGS_ALLOW_TILING)
The algorithm of these modules allow tiling mode both for OpenCL and CPU. A special tiling_callback() is not required as the default fulfills requirements.
Collaborator
|
Thank, Hanno, for updating AgX! LGTMATB (Looks good to me - and the bots) :-) Sorry, I was working and unable to comment before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logical typo for OpenCL fast tiling fitting check
We may not tile if the
piece->tiling readyflag is notTRUE. (This requires themodule->flagsincludingIOP_FLAGS_ALLOW_TILING)Fix some iop modules to support tiling
The algorithm of these modules allow tiling mode both for OpenCL and CPU. A special
tiling_callback()is not required as the default meets requirements. (As these modules have low mem requirements it was not evident performance-wise on most systems).I got aware of this via late comments by @kofa73 and his bots in #22100 (comment)
And - yes - we must respect the
IOP_FLAGS_ALLOW_TILINGflag in all cases.@TurboGit @masterpiga (colorharmoniter) @jandren (contrastntexture) @kofa73 (agx) @MStraeten, if any of us adds new iop modules we must always check
IOP_FLAGS_ALLOW_TILINGcommit_params()tiling_callback()is required