Skip to content

More tiling checks - #22145

Merged
TurboGit merged 2 commits into
darktable-org:masterfrom
jenshannoschwalm:more_tiling_checks
Sep 4, 2026
Merged

More tiling checks#22145
TurboGit merged 2 commits into
darktable-org:masterfrom
jenshannoschwalm:more_tiling_checks

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator

Fix logical typo for OpenCL fast tiling fitting check

We may not tile if the piece->tiling ready flag is not TRUE. (This requires the module->flags including IOP_FLAGS_ALLOW_TILING)

Fix some iop modules to support tiling

The algorithm of these modules allow tiling mode both for OpenCL and CPU. A special tiling_callback() is not required as the default meets requirements. (As these modules have low mem requirements it was not evident performance-wise on most systems).


I got aware of this via late comments by @kofa73 and his bots in #22100 (comment)

And - yes - we must respect the IOP_FLAGS_ALLOW_TILING flag in all cases.

@TurboGit @masterpiga (colorharmoniter) @jandren (contrastntexture) @kofa73 (agx) @MStraeten, if any of us adds new iop modules we must always check

  1. if the module algorithm supports tiling at all add IOP_FLAGS_ALLOW_TILING
  2. possibly override this if OpenCL doesn't do that or other preconditions in commit_params()
  3. check if a dedicated tiling_callback() is required

We may not tile if the piece->tiling ready flag is not TRUE.
(This requires the module->flags including IOP_FLAGS_ALLOW_TILING)
The algorithm of these modules allow tiling mode both for OpenCL and CPU.
A special tiling_callback() is not required as the default fulfills requirements.
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Sep 4, 2026
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug scope: performance doing everything the same but faster scope: codebase making darktable source code easier to manage OpenCL Related to darktable OpenCL code labels Sep 4, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit fafe0b2 into darktable-org:master Sep 4, 2026
6 checks passed
@kofa73

kofa73 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Thank, Hanno, for updating AgX! LGTMATB (Looks good to me - and the bots) :-) Sorry, I was working and unable to comment before.

@jenshannoschwalm
jenshannoschwalm deleted the more_tiling_checks branch September 5, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code scope: codebase making darktable source code easier to manage scope: performance doing everything the same but faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants