Fix sendmail executable permission check - #7483
Merged
BlackDex merged 2 commits intoAug 20, 2026
Merged
Conversation
Contributor
|
As explained in the thread where I've suggested this fix #7445 (comment) this is not actually sufficient. Can you update your PR to use the access check from the suggested |
Contributor
Author
|
Thanks for the correction. I've replaced the mode-bit check with |
BlackDex
force-pushed
the
fix/sendmail-executable-permissions
branch
from
August 20, 2026 15:21
a93fedb to
352546e
Compare
BlackDex
approved these changes
Aug 20, 2026
dfunkt
pushed a commit
to dfunkt/vaultwarden
that referenced
this pull request
Aug 20, 2026
* Fix sendmail executable permission check * Use access check for sendmail command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7445
The previous permission check inspected the Unix mode bits directly and
could reject commands that were executable by the current process.
Use
nix::unistd::accesswithAccessFlags::X_OKto check whether thesendmail command is executable by the running process.
Checks performed:
cargo fmt --checkcargo check --features sqlitecargo test --features sqlite,mysql,postgresqlcargo clippy --features sqlite,mysql,postgresql -- -D warnings