Skip to content

[rlc-9/5.14.0-687.42.1.el9_8] sctp: stream: fully roll back denied add-stream state - #1601

Merged
PlaidCat merged 1 commit into
rlc-9/5.14.0-687.42.1.el9_8from
{shreeya_nebusec_t3}_rlc-9/5.14.0-687.42.1.el9_8
Sep 10, 2026
Merged

[rlc-9/5.14.0-687.42.1.el9_8] sctp: stream: fully roll back denied add-stream state#1601
PlaidCat merged 1 commit into
rlc-9/5.14.0-687.42.1.el9_8from
{shreeya_nebusec_t3}_rlc-9/5.14.0-687.42.1.el9_8

Conversation

@ciq-kernel-automation

Copy link
Copy Markdown

Summary

This PR has been automatically created after successful completion of all CI stages.

Commit Message(s)

sctp: stream: fully roll back denied add-stream state

cve CVE-2026-52929
commit-author Wyatt Feng <bronzed_45_vested@icloud.com>
commit a5f8a90ac9f77c678a9781c0a464b635e0d63e49

Test Results

✅ Build Stage

Architecture Build Time Total Time
x86_64 32m 26s 33m 38s
aarch64 19m 26s 20m 17s

✅ Boot Verification

✅ Kernel Selftests

Architecture Passed Failed Compared Against Status
x86_64 204 51 rlc-9/5.14.0-687.42.1.el9_8 ✅ No regressions
aarch64 150 53 rlc-9/5.14.0-687.42.1.el9_8 ✅ No regressions

✅ LTP Results

Architecture Passed Failed Compared Against Status
x86_64 1456 81 rlc-9/5.14.0-687.42.1.el9_8 ✅ No regressions
aarch64 1429 82 rlc-9/5.14.0-687.42.1.el9_8 ✅ No regressions

🤖 This PR was automatically generated by GitHub Actions
Run ID: 34348734371

cve CVE-2026-52929
commit-author Wyatt Feng <bronzed_45_vested@icloud.com>
commit a5f8a90

When ADD_OUT_STREAMS is denied, SCTP only shrinks the queued chunks and
then lowers outcnt. That leaves removed stream metadata behind, so a
later re-add can reuse a stale ext and hit a null-pointer dereference in
the scheduler get path.

Fix the rollback by tearing down the removed stream state the same way
other stream resizes do. Unschedule the current scheduler state, drop
the removed stream ext state with sctp_stream_outq_migrate(), and then
reschedule the remaining streams.

This keeps scheduler-private RR/FC/PRIO lists consistent while fully
rolling back denied outgoing stream additions.

Fixes: 637784a ("sctp: introduce priority based stream scheduler")
	Cc: stable@kernel.org
	Reported-by: Yuan Tan <yuantan098@gmail.com>
	Reported-by: Yifan Wu <yifanwucs@gmail.com>
	Reported-by: Juefei Pu <tomapufckgml@gmail.com>
	Reported-by: Zhengchuan Liang <zcliangcn@gmail.com>
	Reported-by: Xin Liu <bird@lzu.edu.cn>
	Signed-off-by: Wyatt Feng <bronzed_45_vested@icloud.com>
	Signed-off-by: Ren Wei <n05ec@lzu.edu.cn>
	Acked-by: Xin Long <lucien.xin@gmail.com>
Link: https://patch.msgid.link/d78954ecd94954653ee299400e98d74a03a6f7d3.1780603399.git.bronzed_45_vested@icloud.com
	Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit a5f8a90)
	Signed-off-by: Shreeya Patel <spatel@ciq.com>
@ciq-kernel-automation ciq-kernel-automation Bot added the created-by-kernelci Tag PRs that were automatically created when a user branch was pushed to the repo (kernelCI) label Sep 10, 2026
@shreeya-patel98
shreeya-patel98 requested review from a team September 10, 2026 12:39
@shreeya-patel98 shreeya-patel98 self-assigned this Sep 10, 2026

@bmastbergen bmastbergen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥌

@bmastbergen
bmastbergen requested a review from a team September 10, 2026 13:11

@PlaidCat PlaidCat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PlaidCat
PlaidCat merged commit 0d6a057 into rlc-9/5.14.0-687.42.1.el9_8 Sep 10, 2026
5 of 6 checks passed
@PlaidCat
PlaidCat deleted the {shreeya_nebusec_t3}_rlc-9/5.14.0-687.42.1.el9_8 branch September 10, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by-kernelci Tag PRs that were automatically created when a user branch was pushed to the repo (kernelCI)

Development

Successfully merging this pull request may close these issues.

3 participants