deps: bump the moby group across 1 directory with 2 updates - #131
dependabot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review — da4f040 · CLEAN
Clean review: no findings. This is a Dependabot group bump of moby/moby/api v1.55.0→v1.56.0 and moby/moby/client v0.5.1→v0.6.0 with no code change, and I found no incompatibility with any call site.
What I reviewed
What I verified, by reading the module sources of both versions (downloaded into the module cache; nothing built or executed):
- api diff —
diff -rqof api@v1.55.0 vs api@v1.56.0 shows only docs, swagger, Dockerfile, go.mod/go.sum, and test files changed. No Go type in any package this repo imports (container,mount,network,build) changed. - client diff — no exported signature or type was removed or changed. The only exported changes are the
MaxAPIVersionconst (1.55→1.56, the point of the bump) and a new additiveWithMessagePrinteroption. Everything else is unexported internals: thesendRequest/post/buildRequestfamily reordered body/headers arguments (unreachable from outside the package), avalueOrZerohelper preservingContainerUpdatesemantics, and capability normalization moved from an in-place mutation of the caller'sHostConfigto a non-mutating shallow copy innormalizeHostConfig— semantically identical normalization, and strictly better for callers. - Version pairing — client v0.6.0's go.mod requires api v1.56.0, matching the bump; the dropped intra-monorepo
replacedirective was never applicable downstream.go mod downloadresolved both modules cleanly against the PR's go.mod/go.sum. - Call sites — I enumerated every
client.*symbol this repo uses (client.New,FromEnv,WithHost,Ping, the container/exec/image/network/volume option types and methods acrossruntime/docker/) and each still exists with the same shape. The version-negotiation comment inruntime/docker/client.go:35remains accurate.
Coverage account: I worked interface-contract and correctness (the only dimensions a dependency-only bump can fire under in this repo) and verified the compat surface as above; the conditional dimensions (state-integrity, redelivery, version-compatibility on this repo's own persisted shapes, etc.) have no condition met by a two-line go.mod diff. I reviewed the diff at head da4f040 (1 commit, 2 files). The repository publishes no .dap/code-review.yml; its standard lives in .dap/review/engineering.md, which I read at the base SHA — its out-of-bounds rule for dependency bumps ("beyond an actual incompatibility you can point at in the diff") is satisfied since none exists. I did not run the build or test suite; a go build ./... run by CI would confirm compilation, but source reading found nothing that could break it.
CLEAN — this round found nothing. Reply in a finding's own thread to argue it. On the pull request I answer @dap-code-review-by-crunchloop review, pause and resume.
Bumps the moby group with 2 updates in the / directory: [github.com/moby/moby/api](https://github.com/moby/moby) and [github.com/moby/moby/client](https://github.com/moby/moby). Updates `github.com/moby/moby/api` from 1.55.0 to 1.56.0 - [Release notes](https://github.com/moby/moby/releases) - [Commits](moby/moby@api/v1.55.0...api/v1.56.0) Updates `github.com/moby/moby/client` from 0.5.1 to 0.6.0 - [Release notes](https://github.com/moby/moby/releases) - [Changelog](https://github.com/moby/moby/blob/v0.6.0/CHANGELOG.md) - [Commits](moby/moby@v0.5.1...v0.6.0) --- updated-dependencies: - dependency-name: github.com/moby/moby/api dependency-version: 1.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: moby - dependency-name: github.com/moby/moby/client dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: moby ... Signed-off-by: dependabot[bot] <support@github.com>
da4f040 to
b52f5a6
Compare
Dismissed by DAP code review: b52f5a6 has not been reviewed clean (the pull request was pushed to).
Bumps the moby group with 2 updates in the / directory: github.com/moby/moby/api and github.com/moby/moby/client.
Updates
github.com/moby/moby/apifrom 1.55.0 to 1.56.0Release notes
Sourced from github.com/moby/moby/api's releases.
Commits
9b2179dMerge pull request #53572 from vvoland/api-docs-cut575cf82Merge pull request #53571 from thaJeztah/bump_tools20beedbapi/docs: Cut v1.56bb86302Merge pull request #53569 from vvoland/afvsock-lsm65be55aMerge pull request #53513 from thaJeztah/daemon_fix_list0af79c4Merge pull request #53570 from vvoland/process-release7d1ce6aMerge pull request #53568 from renovate-bot/renovate/github.com-mdlayher-sock...0df1a00Dockerfile: update cli v29.7.2, compose v5.5.1, buildx v0.37.0e1d06bdDrop replace rulesb40d37eMerge pull request #53359 from vvoland/ext-namegeneratorUpdates
github.com/moby/moby/clientfrom 0.5.1 to 0.6.0Release notes
Sourced from github.com/moby/moby/client's releases.
Changelog
Sourced from github.com/moby/moby/client's changelog.
... (truncated)
Commits
f4a4f1cBump to 0.6.0f925eddMerge pull request #1525 from griff/1503-fix12715c8Merge pull request #1609 from jpetazzo/release-docker-with-docker326daddMerge pull request #1565 from dotcloud/only_load_authconfig_when_neededa3510c9Merge pull request #1560 from dotcloud/439-allow-lxc-args262d57eMerge pull request #1623 from mhennings/1592-fix-race-conditions-in-parallel-...551092fAdd lxc-conf flag to allow custom lxc options3f802f4Fix race conditions in parallel pull0b9c8e2Merge pull request #1596 from metalivedev/1149-easyfixes42fe550Merge pull request #1614 from denibertovic/docs