Repository navigation
fix(tools): drop a real storage URL from the URL read tests - #9047
Conversation
Strix Security ReviewWarning This pull request has 60 commits after the last Strix review ( ✅ No open security findings. PR summary: Replaces a real third-party presigned storage URL in the URL read tool tests with a neutral example.com placeholder, keeping the URL extensionless so body-sniffing test coverage is unchanged. Review summaryThe PR replaces a real (truncated) Cloudflare R2 presigned URL used as a test fixture in Review 1 on this PR · Reviewed by Strix |
ba34e3d to
cf6cd68
Compare
The presigned-link fixture used a third-party R2 host and object key. An extensionless example.com placeholder keeps the byte-sniff coverage without publishing that path.
cf6cd68 to
f2e8d0b
Compare
Related issue
Reported by Composio security. No tracking issue yet.
Summary
PRESIGNED_URL.https://example.com/file?X-Amz-Signature=test..pdfsuffix would make the tool trust the path and skip that coverage.Verification
uv run pytest lib/crewai-tools/tests/url_read_tool_test.py— 73 passed.Additional context
The signature on the old link was already truncated, so it did not open the file. The storage path was still in the public repo. This removes it from the current tree. The original commit remains in git history.
Note
Low Risk
Test-only fixture swap with no production code changes; removes sensitive URL leakage from the repo.
Overview
Replaces the
PRESIGNED_URLtest fixture, which previously embedded a real Cloudflare R2 host and object path, with a generichttps://example.com/file?X-Amz-Signature=test.A short comment clarifies that the URL stays extensionless on purpose so presigned-style cases keep exercising body sniffing (PDF, DOCX, HTML, CSV, XLSX) instead of relying on a path suffix. No runtime behavior changes—only test data cleanup after a security report.
Reviewed by Cursor Bugbot for commit f2e8d0b. Bugbot is set up for automated code reviews on this repo. Configure here.