Preserve expiry dates from nested cache collectors - #19509
Draft
timkelty wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a subtle bug in nested element-cache info collection where a nested collector’s expiry could be lost if the parent collector didn’t yet have an expiry, ensuring outer caches can’t outlive expirable content.
Changes:
- Preserve nested cache duration when unwinding nested cache-info collectors (even if the parent duration is currently
null). - Add a unit test that reproduces the nested-collector expiry-loss scenario and asserts the resulting duration is bounded as expected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/services/Elements.php |
Ensures nested collected expiry duration is retained when parent duration hasn’t been set yet. |
tests/unit/services/ElementsTest.php |
Adds coverage validating nested cache collection preserves expiry duration for the outer collector. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested element-cache collectors could discard their expiry when the parent collector did not have one yet. Preserve the nested duration so outer caches cannot outlive expirable content.
Discovered while reviewing #19508.
Supersedes #19507 after the branch was renamed.