Repository navigation
[TRIVIAL] Log a failed quote settlement's bundle at debug level - #5319
Merged
Merged
Conversation
squadgazzz
marked this pull request as ready for review
November 19, 2026 14:55
Contributor
|
Claude finished @squadgazzz's task in 16s —— View job ReviewNo issues found. Merging the trace log into the existing debug log is correct. |
|
🤖 Claude reviewed this PR. Any issues are posted as inline comments on the relevant lines.
Won't run when: the PR is a draft, the author is a bot or lacks write access, or the |
ropusaurio
approved these changes
Nov 19, 2026
ropusaurio
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the log message is maintained so no filters break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every quote settlement that fails in simulation should leave its bundle in the logs, so
decode_bundle --simulate(#5318) can replay it. #5305 logs the bundle at trace level, which only the log filter socket turns on, and a restart turns it off again. The trace ran for an hour on 2026-11-18 and caught 412 bundles, while prod has about 5,400 such failures a day.Initially, I wasn't sure whether we have a bug in our simulation logic, but after testing, this is not the case. So, this PR moves the bundle and its slot into the
quote unverified, its settlement fails in simulationdebug log, which prod already keeps. EVM does the same: when quote verification fails,TradeVerifierlogs a Tenderly resimulation command at debug. The bundle adds about 15 MB of logs a day. The log'slogsfield goes, sincesimulateBundlealways returns it empty for a failed transaction.Changes
failed quote bundletrace logHow to test
Existing tests.
Related issues
BE-406