Skip to content

refactor(next): decouple execution engine from SPARQL AST - #604

Merged
remiceres merged 1 commit into
feature/corese-nextfrom
feature/cleanup-engine-ast-decoupling
Sep 18, 2026
Merged

remiceres merged 1 commit into
feature/corese-nextfrom
feature/cleanup-engine-ast-decoupling

Conversation

@remiceres

Copy link
Copy Markdown
Contributor

Summary

  • Remove AST accessors coreseNextSource() and getFilterExpression() from engine interface Filter
  • Remove TermAst forwarding method getFilterExpression() from Exp
  • Remove QueryAst ast field, getAST(), getGlobalAST(), and setAST() from engine class Query
  • Remove obsolete query.setAST(...) calls from CoreseAstQueryBuilder
  • Empty EXISTING_ENGINE_AST_DEPENDENCIES in NextModuleBoundaryTest, enforcing zero parser/AST dependencies in query/impl/engine
  • Update docs/next-engine-ast-boundary.md and engine/package-info.java

Validation

  • ./gradlew check -x test passed
  • ./gradlew test --tests '*NextModuleBoundaryTest' passed (all boundary tests green with 0 AST exceptions)
  • ./gradlew test --tests 'fr.inria.corese.core.next.*' passed

- Remove AST accessors coreseNextSource() and getFilterExpression() from Filter
- Remove TermAst forwarding from Exp
- Remove QueryAst field and AST accessors from Query
- Remove query.setAST calls from CoreseAstQueryBuilder
- Empty EXISTING_ENGINE_AST_DEPENDENCIES in NextModuleBoundaryTest
- Update boundary documentation and package-info
@remiceres
remiceres merged commit 212afde into feature/corese-next Sep 18, 2026
1 check passed
@remiceres
remiceres deleted the feature/cleanup-engine-ast-decoupling branch September 18, 2026 13:12
@github-actions

Copy link
Copy Markdown
Overall Project 55.51% 🍏
File Coverage
NextFilterFromAst.java 92.8% 🍏
CoreseAstQueryBuilder.java 87.09% 🍏
Query.java 72.32% 🍏
Exp.java 57.11% 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant