Skip to content

fix(vscode): respect disabled automatic inline suggestions - #13272

Open
KayanoLiam wants to merge 1 commit into
continuedev:mainfrom
KayanoLiam:fix/manual-autocomplete-trigger
Open

KayanoLiam wants to merge 1 commit into
continuedev:mainfrom
KayanoLiam:fix/manual-autocomplete-trigger

Conversation

@KayanoLiam

@KayanoLiam KayanoLiam commented Sep 13, 2026

Copy link
Copy Markdown

Summary

Fixes #13242.

  • Ignore Automatic inline-completion requests when the effective editor.inlineSuggest.enabled setting is false, while preserving explicit Invoke requests.
  • Scope the setting lookup to the TextDocument so resource and language overrides are respected.
  • Add regression tests for manual/automatic requests, both language-override precedence directions, and regular autocomplete trigger propagation; document language-scoped configuration.

The guard runs before regular autocomplete / next-edit branching. No public API, dependencies, or lockfiles changed.

Local validation

  • npm --prefix extensions/vscode test -- --run src/autocomplete/__tests__/ContinueCompletionProvider.vitest.ts — 9 passed. The original two regressions failed before adding the guard, then passed.
  • npm --prefix extensions/vscode run vitest — 6 files, 91 tests passed.
  • npm --prefix extensions/vscode run write-build-timestamp && npm --prefix extensions/vscode run tsc:check — passed.
  • npm --prefix extensions/vscode run lint — passed, 0 errors / 219 warnings.
  • npx prettier --check extensions/vscode/src/autocomplete/completionProvider.ts extensions/vscode/src/autocomplete/__tests__/ContinueCompletionProvider.vitest.ts docs/customize/deep-dives/autocomplete.mdx — passed.
  • npm --prefix extensions/vscode run esbuild — passed.
  • git diff --check — passed.

Local setup initially needed built workspace packages, the generated build timestamp, sqlite3 rebuild, and the ignored extension build directory; checks passed after completing those prerequisites. npm audit findings and lint warnings remain.

Limitations

No real-editor E2E or complete VSIX/native-target packaging matrix was run locally. Unit tests cover provider behavior, not the actual VS Code keystroke loop. GitHub CI results are separate and pending at publication.

GitHub CI results

For commit 3d958995a47f9cd880c54fdad7305d3ede891829: 54 checks reached terminal status — 47 passed, 3 reported failed, 4 skipped. CLA, VS Code checks, all 10 existing E2E checks, core/GUI/binary/package checks, the Node/OS test matrix, and Linux/Windows VSIX jobs passed. Existing E2E passing does not establish coverage of this exact keystroke reproduction.

Outstanding CI blockers:

  • JetBrains setup: AnimMouse/setup-ffmpeg@v1 failed downloading/extracting FFmpeg 7.1 (xz: (stdin): File format not recognized, tar exit 2). Tests were skipped, not passed.
  • macOS ARM64 VSIX job: build and artifact uploads succeeded, but the job/run was cancelled during post-job cleanup. Cancellation cause is unknown; the check is not green.
  • Required-check gate: failed because jetbrains-tests failed.

Rerun requests for both affected jobs were rejected with HTTP 403 (Must have admin rights to Repository). Maintainer reruns are needed. These failures are not claimed to be transient or resolved.

@KayanoLiam
KayanoLiam requested a review from a team as a code owner September 13, 2026 14:18
@KayanoLiam
KayanoLiam requested review from sestinj and removed request for a team September 13, 2026 14:18
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@SparkByte-main

Copy link
Copy Markdown

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@KayanoLiam

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@KayanoLiam

Copy link
Copy Markdown
Author

CI update for 3d95899: CLA is now passing. 47 checks passed, 3 failed, 4 skipped; none pending. VS Code checks and all 10 existing E2E checks passed.

Could a maintainer please rerun the affected jobs?

I attempted rerun requests for both jobs, but GitHub returned HTTP 403 (Must have admin rights to Repository). Neither failure is being treated as resolved or assumed flaky. Full local commands and CI findings are recorded in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger Key for autocomplete suggestions not working

2 participants