fix(vscode): respect disabled automatic inline suggestions - #13272
Open
KayanoLiam wants to merge 1 commit into
Open
KayanoLiam wants to merge 1 commit into
KayanoLiam wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
3 tasks
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
CI update for 3d95899: CLA is now passing. 47 checks passed, 3 failed, 4 skipped; none pending. VS Code checks and all 10 existing E2E checks passed. Could a maintainer please rerun the affected jobs?
I attempted rerun requests for both jobs, but GitHub returned HTTP 403 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13242.
Automaticinline-completion requests when the effectiveeditor.inlineSuggest.enabledsetting is false, while preserving explicitInvokerequests.TextDocumentso resource and language overrides are respected.The guard runs before regular autocomplete / next-edit branching. No public API, dependencies, or lockfiles changed.
Local validation
npm --prefix extensions/vscode test -- --run src/autocomplete/__tests__/ContinueCompletionProvider.vitest.ts— 9 passed. The original two regressions failed before adding the guard, then passed.npm --prefix extensions/vscode run vitest— 6 files, 91 tests passed.npm --prefix extensions/vscode run write-build-timestamp && npm --prefix extensions/vscode run tsc:check— passed.npm --prefix extensions/vscode run lint— passed, 0 errors / 219 warnings.npx prettier --check extensions/vscode/src/autocomplete/completionProvider.ts extensions/vscode/src/autocomplete/__tests__/ContinueCompletionProvider.vitest.ts docs/customize/deep-dives/autocomplete.mdx— passed.npm --prefix extensions/vscode run esbuild— passed.git diff --check— passed.Local setup initially needed built workspace packages, the generated build timestamp, sqlite3 rebuild, and the ignored extension build directory; checks passed after completing those prerequisites. npm audit findings and lint warnings remain.
Limitations
No real-editor E2E or complete VSIX/native-target packaging matrix was run locally. Unit tests cover provider behavior, not the actual VS Code keystroke loop. GitHub CI results are separate and pending at publication.
GitHub CI results
For commit
3d958995a47f9cd880c54fdad7305d3ede891829: 54 checks reached terminal status — 47 passed, 3 reported failed, 4 skipped. CLA, VS Code checks, all 10 existing E2E checks, core/GUI/binary/package checks, the Node/OS test matrix, and Linux/Windows VSIX jobs passed. Existing E2E passing does not establish coverage of this exact keystroke reproduction.Outstanding CI blockers:
AnimMouse/setup-ffmpeg@v1failed downloading/extracting FFmpeg 7.1 (xz: (stdin): File format not recognized, tar exit 2). Tests were skipped, not passed.jetbrains-testsfailed.Rerun requests for both affected jobs were rejected with HTTP 403 (
Must have admin rights to Repository). Maintainer reruns are needed. These failures are not claimed to be transient or resolved.