fix(ollama): preserve tools across agent loop turns - #13258
Open
dvd233 wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13254.
Ollama chat requests only attached tool definitions when the last converted message had the
userrole. After Continue executed the first tool, the next Agent-mode request ended with atoolresult, sotoolsdisappeared from the request body and Ollama could not select the next tool.Attach configured tools whenever
CompletionOptions.toolsis non-empty. This matches Ollama's current multi-turn agent-loop examples, which pass the available tools on every loop iteration, including after appending tool results.AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Not applicable; this is an outbound request-construction bug covered by a focused regression test.
Tests
body.toolsisundefined, while the 10 existing Ollama tests passnpm test --prefix core -- --runInBand llm/llms/Ollama.test.ts(11/11 passed)npm run tsc:check --prefix coregit diff --check