Conversation
…tainer Container, ContainerFactory, ProcessFactory and ContainerTemplate each had a single implementation in a private binary crate. Collapse them into one concrete Container struct and make TaskService non-generic. - Container owns InitProcess and a map of ExecProcess, with create() and exec() replacing RuncFactory and RuncExecFactory. - Exec processes derive runtime, bundle and IO ownership from the init lifecycle instead of a factory holding copies. - TaskService owns the injectable Spawner directly (ShimExecutor by default). - Split bundle preparation from init process creation; derive container id/bundle from the init process. - Drop the no-op factory cleanup hook and the unused CreateConfig. No behavior change intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify runc shim internals:
Container,ContainerFactory,ProcessFactoryandContainerTemplateeach had a single implementation. In this PR they collapse into one concreteContainerand makesTaskServicenon-generic.Container::create/execreplaceRuncFactory/RuncExecFactory.TaskServiceowns the injectableSpawnerdirectly.cleanuphook and unusedCreateConfig.