Fix thematic break after a link reference definition - #628
Merged
jgm merged 1 commit intoSep 1, 2026
Conversation
A line of dashes after a refdef was scanned as a setext underline and never rechecked as a thematic break, so `[f]:r\n---` rendered as `<p>---</p>` instead of `<hr />`. Only treat the line as a setext heading when paragraph content remains after resolving refdefs. Fixes commonmark#619
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line of dashes immediately after a link reference definition was scanned as a setext underline. After the refdef was consumed, that line never fell through to the thematic-break check, so
rendered as
<p>---</p>instead of<hr />. Other thematic breaks (***,___,- - -) already worked because they are not setext underlines.Only treat a candidate setext underline as a heading when paragraph content remains after resolving reference definitions. Otherwise fall through so
---can still be a thematic break.Fixes #619