Skip to content

Select the membership tier when a custom amount is typed - #120

Merged
joaquimds merged 1 commit into
masterfrom
fix/custom-amount-selects-tier
Sep 22, 2026
Merged

joaquimds merged 1 commit into
masterfrom
fix/custom-amount-selects-tier

Conversation

@joaquimds

@joaquimds joaquimds commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Typing into a tier's custom amount input now selects that tier. Previously the default tier stayed selected, the custom amount was ignored server-side, and members were charged the default plan price (reported by London Renters Union). The auto-select added in e5cd21b was lost when PlanRadioPanel replaced RadioPanel in edd05b4.
  • Fix theme colour fallbacks in theme.scss: var(--a, --b, #hex) is an invalid fallback, so buttons and the background lost their colour whenever the block's primary colour was not set.
  • Stub /join/v1/* in the webpack dev server so the standalone harness can progress past the details page.

Test plan

  • New Jest test plan.page.test.tsx fails without the fix and passes with it; full suite passes (55 tests).
  • Verified in the local harness with multi-currency plans that typing a custom amount keeps the tier selected and the submitted state carries the custom amount.
  • Verify on a single-currency site with a custom tier that typing in the box without clicking the radio selects it.

🤖 Generated with Claude Code

Typing into a tier's custom amount box without clicking its radio left
the default tier selected, so the custom amount was ignored on submit
and members were charged the default plan price. The auto-select from
e5cd21b was lost when PlanRadioPanel replaced RadioPanel in edd05b4.

Also fix the theme colour fallbacks in theme.scss, which used
var(--a, --b, #hex) and so dropped the property entirely when the
primary colour was not set, and stub the /join/v1/* REST routes in the
webpack dev server so the standalone harness can progress past the
details page.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@joaquimds
joaquimds merged commit 89187da into master Sep 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant