Skip to content

ci: update release workflow settings - #223

Merged
sreya merged 1 commit into
mainfrom
release-workflow-settings
Nov 18, 2026
Merged

sreya merged 1 commit into
mainfrom
release-workflow-settings

Conversation

@sreya

@sreya sreya commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sreya
sreya force-pushed the release-workflow-settings branch from 65807e5 to 870e5bb Compare November 18, 2026 21:13
@sreya
sreya marked this pull request as ready for review November 18, 2026 22:43
@sreya
sreya requested a review from a team as a code owner November 18, 2026 22:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T22:45:52.185159Z 870e5bb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sreya
sreya merged commit 835eb27 into main Nov 18, 2026
11 checks passed
@kylecarbs
kylecarbs deleted the release-workflow-settings branch November 18, 2026 22:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 870e5bbf7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/release.md
Before the first automated stable release:

- Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`.
- Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`, one for each of the `npm-release` and `npm-next` environments.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Configure required reviewers for the release environment

In repositories where npm-release has not already been configured, this runbook never tells an administrator to add required reviewers, so the promised approval gate is not enforced. GitHub automatically creates a referenced environment without protection rules, and merely setting environment: npm-release does not require approval; the tag-triggered job can therefore publish immediately. Add creation of the environment and its required-reviewer protection to the admin setup. GitHub documents the auto-creation behavior and lack of default protections here.

Useful? React with 👍 / 👎.

Comment thread docs/release.md
Before the first automated stable release:

- Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`.
- Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`, one for each of the `npm-release` and `npm-next` environments.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Enable direct publishing for every trusted publisher

For the new environment-specific trusted publishers created by following this instruction, the workflow's npm publish commands will be rejected unless the administrator explicitly enables direct publishing. Since September 3, 2026, new npm trusted-publisher configurations allow staged publishing by default and require opting into npm publish; npm dist-tag also needs its own permission for the documented recovery path. Update the setup step to require both allowed actions for all four package/environment configurations. The npm trusted-publishing documentation describes these action permissions and defaults.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants