Repository navigation
ci: update release workflow settings - #223
Conversation
65807e5 to
870e5bb
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 870e5bbf7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Before the first automated stable release: | ||
|
|
||
| - Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`. | ||
| - Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`, one for each of the `npm-release` and `npm-next` environments. |
There was a problem hiding this comment.
Configure required reviewers for the release environment
In repositories where npm-release has not already been configured, this runbook never tells an administrator to add required reviewers, so the promised approval gate is not enforced. GitHub automatically creates a referenced environment without protection rules, and merely setting environment: npm-release does not require approval; the tag-triggered job can therefore publish immediately. Add creation of the environment and its required-reviewer protection to the admin setup. GitHub documents the auto-creation behavior and lack of default protections here.
Useful? React with 👍 / 👎.
| Before the first automated stable release: | ||
|
|
||
| - Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`. | ||
| - Configure npm trusted publishers for both `ghostty-web` and `@ghostty-web/demo` for `.github/workflows/publish.yml`, one for each of the `npm-release` and `npm-next` environments. |
There was a problem hiding this comment.
Enable direct publishing for every trusted publisher
For the new environment-specific trusted publishers created by following this instruction, the workflow's npm publish commands will be rejected unless the administrator explicitly enables direct publishing. Since September 3, 2026, new npm trusted-publisher configurations allow staged publishing by default and require opting into npm publish; npm dist-tag also needs its own permission for the documented recovery path. Update the setup step to require both allowed actions for all four package/environment configurations. The npm trusted-publishing documentation describes these action permissions and defaults.
Useful? React with 👍 / 👎.
No description provided.