Repository navigation
fix(deps): resolve all critical and high security advisories - #846
Merged
Merged
Conversation
- Upgrade better-auth and @better-auth/sso to 1.7.19 (critical OAuth state / magic link advisory)
- Upgrade legacy Astro docs app to Astro 7 (critical AVIF RCE) and scope JSX renderers
- Upgrade sharp, adm-zip, nodemailer, mailparser, liquidjs, razorpay, swagger-ui-react,
OpenTelemetry (0.223), tiptap, nanoid and postcss
- Move web and queue to zod 4 and @hookform/resolvers 5; adapt z.record() calls
- Adopt the OpenTelemetry logRecordProcessors / BatchLogRecordProcessor({ exporter }) API
- Refresh pnpm overrides so transitive deps resolve to patched versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears every critical and high advisory reported by
pnpm auditonmain.Direct dependency upgrades
apps/docssite, with@astrojs/preact6 and@astrojs/react7. Fixes the critical AVIF image-optimisation RCE. The site builds without source changes. I scoped the Preact and React renderers withincludeso they don't conflict, and git-ignored the generated.astro/directory.apps/webandapps/queue. No zod 3 release is patched for the memory-exhaustion advisory. Also bumped@hookform/resolvers3 → 5 andreact-hook-formto 7.91. Code change:z.record(v)→z.record(z.string(), v)in the queue.logRecordProcessors: [...]andBatchLogRecordProcessor({ exporter })API.Transitive dependencies
Refreshed
pnpm.overridesso transitive packages resolve to patched versions. Each override is scoped to a major version where several majors coexist (minimatch, brace-expansion, js-yaml, rollup, nanoid, etc.). Outdated pins that had become vulnerable themselves (axios, fast-uri, @xmldom/xmldom, form-data, fast-xml-parser, protobufjs) now point at patched ranges. The@hookform/resolvers@3packageExtension is no longer needed and was removed.Verification
pnpm audit: 0 critical, 0 highpnpm test: 100 suites, 835 tests passpnpm lint: cleantsc --noEmitpasses forapps/webandapps/queuepnpm --filter @courselit/web buildsucceeds. The generatedopenapi.jsonis semantically identical.packages/*build.apps/docs(Astro 7) builds all 65 pages.E2E browser smoke test
Run against local Mongo (replica set), Redis and Mailpit, with the queue and web apps running:
/swagger(swagger-ui-react 5.34) loads and renders the spec.Notes
next start(NODE_ENV=production) over plain http redirects/dashboardback to/login. The proxy's auth instance has nobaseURL, so better-auth expects__Secure-cookie names. The cookie-prefix logic is identical in 1.6.34, so this is pre-existing and doesn't affect HTTPS deployments. I usednext devfor the logged-in part of the smoke test.[tiptap warn]: Duplicate extension namesconsole warning is pre-existing. StarterKit v3 already bundles link, dropcursor, gapcursor and heading.