Fix both Rust test failures - #103
Open
thomasjm wants to merge 2 commits into
Open
Conversation
thomasjm
force-pushed
the
rust-data-science-start-timeout
branch
from
August 28, 2026 08:21
6aae2c0 to
c684682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated causes behind the rust jobs failing.
use polars...— kernel start timeoutNot a compile error: evcxr builds polars, ndarray, plotters and smartcore at kernel startup, past
papermill's
--start-timeout, which was hardcoded at 120. The cell has no outputs at all inout.ipynbbecause nothing ever executed. That test takes ~141s here, so 120 is marginally too loweven on this machine and well short on a loaded runner. Reproduces locally every time.
runKernelCode/notebookShouldSatisfynow take the timeout,defaultStartTimeout = 120keepsevery other caller unchanged, and
testKernelSucceeds'lets the one slow test ask for 600. Raisingthe global default instead would make every hung kernel take five times longer to report.
test.rs with missing struct field— batch-dependent assertionThis one passes locally and fails in CI. rust-analyzer publishes its own diagnostics first and
rustc's later once flycheck runs, so which of them share a batch varies by machine and load. The
test asserted the batch equalled exactly one entry, which only holds if a batch happens to contain
rustc's diagnostic alone.
Concretely: CI's last received batch had all three (rust-analyzer's
non_upper_case_globalsandE0063, plus rustc's E0063) so nothing ever matched; the local run's had rustc's alone, so it passed.
New
assertDiagnosticRangesContain'asserts the expected diagnostics are among those published andignores the rest, which is stable regardless of how they get batched.
Testing
Both fail on
mainlocally in their respective environments and pass with this change.For the assertion I also checked it isn't vacuous: changing the expected message to a nonexistent
one (
missing field \zzz``) makes it fail, as it should.