fix: prevent ValueError when slug is missing in upload - #769
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
uploadcommand would raise aValueError: The provided slug is invalidif no--slugargument was provided and the CI adapter could not auto-detect a slug. TheNonevalue forslugwas being passed toencode_slug(), which then failed validation.The fix introduces an early validation check within the
do_upload_logicfunction. If theslugparameter isNoneor otherwise invalid, aclick.ClickExceptionis now raised with a clear, user-friendly message. This guides the user to provide the--slugoption in the correct format, preventing the unhelpfulValueErrorand improving the overall user experience.Fixes CLI-GH
This PR was automatically generated by Sentry. You can adjust this setting at any time.