fix: strip token whitespace to prevent invalid Authorization header - #767
Open
sentry[bot] wants to merge 1 commit into
Open
fix: strip token whitespace to prevent invalid Authorization header#767sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
ValueError: Invalid header valuethat occurs when the Codecov token contains trailing whitespace, such as a newline character. This typically happens when the token is read from an environment variable or file that includes such characters.The fix involves adding
.strip()to the token string before it is interpolated into theAuthorizationheader in bothget_token_headerandget_token_header_or_failfunctions withincodecov_cli/helpers/request.py. This ensures that any leading or trailing whitespace is removed, guaranteeing a valid HTTP header format.Fixes CLI-BS
This PR was automatically generated by Sentry. You can adjust this setting at any time.