fix(deps): resolve the contract packages at the versions the manifest pins - #778
Merged
Merged
Conversation
… pins #764 bumped ocp to 0.4.0 and #769 bumped flipcash2 to 0.6.0 without regenerating the workspace's Package.resolved, so it still recorded 0.3.0 and 0.5.0. Xcode Cloud archives with automatic dependency resolution disabled, which turns that mismatch into a hard error rather than a silent re-resolve: "Deploy Flipcash" build #542 failed with "an out-of-date resolved file was detected". The vector gate builds the SPM schemes with resolution enabled and never opens Code.xcodeproj, so it stayed green. Regenerated with xcodebuild -resolvePackageDependencies. Only the two contract entries and originHash move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace
Package.resolvedstill recordedocp-client-protocolat0.3.0andflipcash2-client-protocolat0.5.0, whileFlipcashAPI/Package.swiftpins0.4.0and0.6.0after #764 and #769. Neither PR regenerated the lock.Xcode Cloud archives with automatic dependency resolution disabled, so a stale lock is a hard error rather than a silent re-resolve. "Deploy Flipcash" build #542 failed on
mainwith:The vector gate never caught it: it builds the
CrossPlatformVectors-PackageandFlipcashCoreVectors-Packageschemes with resolution enabled and never opensCode.xcodeproj, andFlipcashCoredoes not depend onFlipcashAPI.Regenerated with
xcodebuild -resolvePackageDependencies. The diff is the two contract entries andoriginHash; no other dependency moves. The recorded revisions are the release tags' commits —301a07affor flipcash20.6.0,15ce331dfor ocp0.4.0.