refactor(discrete-curve): delegate DiscreteBondingCurve to SharedCoreKit - #731
Draft
bmc08gt wants to merge 2 commits into
Draft
refactor(discrete-curve): delegate DiscreteBondingCurve to SharedCoreKit#731bmc08gt wants to merge 2 commits into
bmc08gt wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiscreteBondingCurve.swift's low-level methods now delegate toSharedCoreKit.SharedDiscreteCurve; the high-levelbuy/sell/marketCapAPI is untouched.UInt128andDiscreteCurveTablestypes now that the shared module owns that logic.DiscreteBondingCurveTests.swiftthat asserted on the now-deleted internal types; equivalent coverage lives in the shared KMP module's own fixture-based tests.This is a draft:
SharedDiscreteCurvecurrently only exists via a manual copy into ephemeral build caches, not through a publishedflipcash-shared-core-spmrelease, so CI cannot build clean until the companion code-android-app PR merges and SharedCore is republished.