Skip to content

fix: manually bump deps - #739

Merged
aramprice merged 4 commits into
mainfrom
manual-bump-deps
Sep 15, 2026
Merged

aramprice merged 4 commits into
mainfrom
manual-bump-deps

Conversation

@aramprice

Copy link
Copy Markdown
Member

required because of change in fake's package name

required because of change in fake's package name
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 80c193cc-639a-4fa9-b653-9c76ef5cfc35

📥 Commits

Reviewing files that changed from the base of the PR and between 8452ed2 and cb06a25.

📒 Files selected for processing (4)
  • cmd/uaa_login_strategy.go
  • director/factory_config_test.go
  • main.go
  • uaa/factory_config_test.go

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The module now targets Go 1.26.0 and uses newer direct and indirect dependency versions. Four test files now import blobstore fakes from github.com/cloudfoundry/bosh-utils/blobstore/blobstorefakes. CLI messages use explicit %s formatting. Director and UAA tests now match current URL parsing errors.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to cb06a

The dependency, import, formatting, and test-alignment changes present no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 8 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the main dependency updates. It also relates to the fake package import changes and lint fixes, although it does not describe every change.
Description check ✅ Passed The description relates directly to the updated fake package import paths in the test files. It is brief but not unrelated to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch manual-bump-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 15, 2026
@aramprice
aramprice merged commit 69ad484 into main Sep 15, 2026
50 checks passed
@aramprice
aramprice deleted the manual-bump-deps branch September 15, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants