Switch dependency managment to uv - #1164
Conversation
33e294e to
aa5ae89
Compare
|
|
||
| if len(excl_dates) > 0: | ||
| if not isinstance(rrules, rruleset): | ||
| rrules = rruleset().rrule(rrules) |
There was a problem hiding this comment.
We don't pin types-python-dateutil (same as before) so this changed. IMO that's fine.
There was a problem hiding this comment.
I think we should pin stuff for the sake of CI, no?
| description = "Close's email sync engine." | ||
| requires-python = "==3.12.*" | ||
| dependencies = [ | ||
| "alembic==1.7.5", |
There was a problem hiding this comment.
Are all of these direct dependencies? Or will we separately prune them so that the lockfile contains all dependencies and this list only contains what we directly depend on?
There was a problem hiding this comment.
There are probably some stale indirect dependencies there. I'll do a follow up PR with a cleanup.
| "types-boto", | ||
| "types-python-dateutil", | ||
| "types-pytz", | ||
| "types-PyYAML", | ||
| "types-redis", | ||
| "types-requests", |
There was a problem hiding this comment.
Can we pin those? I don't think our CI should start failing just because something new got released.
There was a problem hiding this comment.
Yeah I don't see a reason why these were not pinned in the first place.
I'll do it in follow up to keep this PR changes to just pip-tools -> uv.
2 participants
Similar approach to:
uvinstead ofpipfor building & dependency management socketshark#354refs: BEP-56