Repository navigation
Keep exact Maven paths when uploading RCs with Vercel CLI 65 - #35
Merged
Merged
Conversation
The 1.0.0-rc.2 upload stored every file under a random suffix, for example chdb-bom-1.0.0-rc.2-YLlw8aJ8tD72Eqbykt6gXZHzCt4c66.pom. The script took the CLI from @latest, and Vercel CLI 65 treats --add-random-suffix and --allow-overwrite (now --force) as switches: the "false" passed after each switched it on. The CLI also prints its listing on stderr now, so blob_exists saw no output and the preflight passed for paths that existed. The CLI is now pinned to 65.11.0 and called with its switch syntax, the listing is read from stderr as well, rollback deletes by the URL the upload reported and passes --yes, and every upload is checked to have landed on its exact Maven path; one that did not is rolled back with the rest. Checked against the production store with a throwaway artifact: it is stored at its exact path, maven.chdb.io serves it unchanged, and a second run is refused by the preflight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.0.0-rc.2 upload stored every file under a random suffix, for example
chdb-bom-1.0.0-rc.2-YLlw8aJ8tD72Eqbykt6gXZHzCt4c66.pom, so none of them was at its Maven path.publish-rc-repository.shtook the CLI from@latest, and Vercel CLI 65 treats--add-random-suffixand--allow-overwrite(now--force) as switches: thefalsepassed after each switched it on. The CLI also prints its listing on stderr now, soblob_existssaw no output and the preflight would have passed for paths that already existed.The 59 suffixed blobs have been deleted (the rc.1 blobs are untouched), and rc.2 was uploaded again with this version of the script.
vercel@65.11.0and called with its switch syntax: no--add-random-suffix, no--force,--multipart,--store.blob_existsreads the listing from stderr as well.--yes.Checked against the production store with a throwaway artifact (
com/clickhouse/chdb/chdb-upload-check/0.0.0/…, since deleted): it was stored at its exact path, maven.chdb.io served it byte for byte, and a second run was refused by the preflight.🤖 Generated with Claude Code
Note
Pin Vercel CLI 65 in RC upload script and verify exact blob paths
Updates publish-rc-repository.sh to run blob commands through
npxwith Vercel CLI 65.11.0 instead of picking a CLI from PATH or installing the latest. Passes the store ID via--storeinstead of--store-id.blob_existsnow matches the target name against both stdout and stderr of the blob-list output.--yesand names the failed value in error messages.Macroscope summarized a37a3b2.