Skip to content

Normalize malformed nested key errors #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Normalize malformed nested key errors #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1f738c
Load URI before normalizing malformed keys
Aug 29, 2026
287f739
Normalize deeply nested malformed key errors
Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/cose/key.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
require "cose/key/rsa"
require "cose/key/symmetric"
require "openssl"
require "uri"

@santiagorodriguez96 santiagorodriguez96 Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, worth calling out: this does more than load a constant. The cbor gem only calls URI.parse for CBOR tag 32 if URI is already defined, so this require turns tag-32 parsing on process-wide, which changes how CBOR data decodes everywhere in the app – not just inside cose-ruby. Two things change for any CBOR.decode call:

  • tag-32 values come back as URI objects instead of CBOR::Tagged
  • input that decoded fine before can now raise URI::InvalidURIError
require "cbor"
bytes = CBOR::Tagged.new(32, "https://example.com").to_cbor
CBOR.decode(bytes).class  # => CBOR::Tagged
require "uri"
CBOR.decode(bytes).class  # => URI::HTTPS

Low impact in practice, since Rails and webauthn-ruby load uri anyway. But I think it needs a CHANGELOG entry, and it makes this a minor bump rather than a patch.


module COSE
class Error < StandardError; end
Expand Down Expand Up @@ -52,7 +53,8 @@ def self.deserialize(data)

def self.cbor_decode(data)
CBOR.decode(data)
rescue CBOR::MalformedFormatError, EOFError, FloatDomainError, RegexpError, TypeError, URI::InvalidURIError
rescue CBOR::MalformedFormatError, CBOR::StackError, EOFError, FloatDomainError, RegexpError, TypeError,

@santiagorodriguez96 santiagorodriguez96 Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rescue CBOR::MalformedFormatError, CBOR::StackError, EOFError, FloatDomainError, RegexpError, TypeError,
rescue CBOR::UnpackError, EOFError, FloatDomainError, RegexpError, TypeError,

https://github.com/cabo/cbor-ruby/blob/89e94f3b059deb58478eab51996f764fcc6ecd82/doclib/cbor/error.rb#L3-L10

URI::InvalidURIError
raise COSE::MalformedKeyError, "Malformed CBOR key input"
end
end
Expand Down