Repository navigation
make GetRestPoseBoneTransforms agnostic to cmf/granny - #156
Merged
Merged
Conversation
theagentd
approved these changes
Nov 16, 2026
ccpisheden
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://fenriscreations.atlassian.net/browse/PLAT-12380
We know that the flickering is caused by the outdated math library. The default constructor of Matrix, called in this function GetRestPoseBoneTransforms, is not properly initializing the values in the old version of the library.
However, I suspect that GetRestPoseBoneTransforms could also cause more problems related to flickering. It only contained a cmf code path, and did not handle granny. I believe this could cause problems. when the following conditions hold:
This pull request makes that function agnostic to cmf/granny.
There is an argument to be made that the function shouldn't exist at all. But that is a separate ticket, unrelated to the flickering. https://fenriscreations.atlassian.net/browse/PLAT-12293