Repository navigation
Conversation
Stop printing the Authentik request config, return only the fields the applicant portal displays from verifyotpsession, and only follow same-origin return_to and redirect_uri targets.
Require https and a LinkedIn or GitHub host on both server paths, and only open https links from the recruitment board.
SameSite=Lax, Secure in production, 24h max age, no empty sessions, and no urlencoded parsing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthentikClient.verifyotpsessionnow returns only the fields the applicant portal displays (ATSDashboard.tsxreads exactly these) viatoApplicantApplication.return_toandredirect_urion login are resolved against the server's own origin (resolveSameOriginPath); anything else falls back to/.isAllowedProfileLinkhelper (https, expected host) on both apply and profile update, and the recruitment board only opens https links withnoopener,noreferrer.SameSite=Lax,Securein production, 24h max age,saveUninitialized: false. The urlencoded body parser is removed; nothing in the server or webui posts form bodies.Behavior notes
redirect_uripassthrough (used by the API docs shim for same-origin only) no longer redirects off-site.Testing
tsc --noEmitclean, Prettier clean on changed files.auth-redirects.test.js,profile-links.test.js).app.tscookie options, sinceapp.tscannot be imported without starting the server. Moving the options tosrc/config/session.tswould allow that.