Skip to content

fix(nip56): address post-merge review findings on report ingestion - #786

Merged
Priyanshubhartistm merged 3 commits into
cameri:mainfrom
Priyanshubhartistm:fix/nip56-report-ingestion-gaps
Sep 25, 2026
Merged

Priyanshubhartistm merged 3 commits into
cameri:mainfrom
Priyanshubhartistm:fix/nip56-report-ingestion-gaps

Conversation

@Priyanshubhartistm

Copy link
Copy Markdown
Collaborator

Description

Following up on #770 after a collaborator review on the merged PR turned up four real bugs in report ingestion: dead rows for targetless reports, silent truncation of multi-target reports, non-atomic inserts across a report's rows, and the first report after a restart blocking on a cold WoT graph rebuild. Fixed all four.

Related Issue

Closes #785

Motivation and Context

All four bugs were already live on main

Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
@changeset-bot

changeset-bot Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2277916

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the unnecessary Redis connection at boot is non-blocking.

Findings

  1. P2 Redis connects with WoT disabled ▶
Summary

The PR makes report-row insertion transactional, skips targetless rows, raises the target cap, and starts WoT graph warm-up at worker boot.

  • The boot call also opens Redis when WoT is disabled.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Worker boot] --> B[getCache]
  B --> C[Redis adapter connects]
  C --> D[WoT factory]
  D --> E{WoT enabled?}
  E -- Yes --> F[Start graph warm-up]
  E -- No --> G[Skip warm-up]
Loading

Reviews (2) · Last reviewed commit: "fix(nip56): WoT warm-up and target cap"

Comment thread src/services/wot-graph-service.ts
Comment thread src/factories/wot-graph-service-factory.ts
Comment thread src/utils/nip56.ts
@Priyanshubhartistm Priyanshubhartistm changed the title [BUG] NIP-56 report ingestion: dead rows, WoT-rebuild blocking, target truncation, no transaction fix(nip56): address post-merge review findings on report ingestion Sep 24, 2026
@coveralls

coveralls commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage is 72.466% — Priyanshubhartistm:fix/nip56-report-ingestion-gaps into cameri:main. No base build found for cameri:main.

Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
@Priyanshubhartistm Priyanshubhartistm changed the title fix(nip56): address post-merge review findings on report ingestion fix(nip56): address post-merge review findings on report ingestion Sep 24, 2026
Comment thread src/factories/worker-factory.ts
@Priyanshubhartistm
Priyanshubhartistm merged commit e87e1af into cameri:main Sep 25, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NIP-56 report ingestion: dead rows, WoT-rebuild blocking, target truncation, no transaction

3 participants