Conversation
Filament's checkbox input is an inline-block on a 20px line box, so align-middle pins it to the baseline plus half the x-height instead of the line box centre, leaving it 2px below the row centre. Drop it out of text flow so the cell centres the box itself. Affects the select-all checkbox and every row checkbox in the dashboard tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkboxes were part of the text flow, which caused align-middle to align them against the text baseline instead of the center of the table row. This left them about 2px too low.
This change takes the checkboxes out of the text flow and let the table cell center the checkbox itself.
Affects the select-all checkbox and every row checkbox in the dashboard tables.
Before:
After:
