-
Notifications
You must be signed in to change notification settings - Fork 19
Add cfgs to distinguish WASIp3 and WASIp2 targets
#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamrk
wants to merge
12
commits into
bytecodealliance:main
Choose a base branch
from
adamrk:abk/p3-feature-base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
42d7884
add p3 feature
adamrk 4a6e65c
add p3 test CI job
adamrk ea32edf
use cfg alias
adamrk adb35fc
switch from feature to target
adamrk 7e37d58
Merge branch 'main' into abk/p3-feature-base
adamrk 26bea8b
merge fixes
adamrk 6435d57
add job printing rust version
adamrk 663c532
try override instead of default
adamrk d306e06
explicitly add wasi targets
adamrk 2f8c1c2
bump msrv to latest version with p3 target_env
adamrk 5841233
include target_os in directives
adamrk 14e1bce
remove build-std
adamrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,13 +27,18 @@ http.workspace = true | |
| itoa.workspace = true | ||
| pin-project-lite.workspace = true | ||
| slab.workspace = true | ||
| wasip2.workspace = true | ||
| wstd-macro.workspace = true | ||
|
|
||
| # optional | ||
| serde = { workspace = true, optional = true } | ||
| serde_json = { workspace = true, optional = true } | ||
|
|
||
| [target.'cfg(all(target_os = "wasi", target_env = "p2"))'.dependencies] | ||
| wasip2.workspace = true | ||
|
|
||
| [target.'cfg(all(target_os = "wasi", target_env = "p3"))'.dependencies] | ||
| wasip3.workspace = true | ||
|
|
||
| [dev-dependencies] | ||
| anyhow.workspace = true | ||
| clap.workspace = true | ||
|
|
@@ -59,7 +64,7 @@ license = "Apache-2.0 WITH LLVM-exception" | |
| repository = "https://github.com/bytecodealliance/wstd" | ||
| keywords = ["WebAssembly", "async", "stdlib", "Components"] | ||
| categories = ["wasm", "asynchronous"] | ||
| rust-version = "1.91.1" | ||
| rust-version = "1.92.0" | ||
|
Comment on lines
-62
to
+67
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Had to bump the msrv because |
||
| authors = [ | ||
| "Yoshua Wuyts <rust@yosh.is>", | ||
| "Pat Hickey <pat@moreproductive.org>", | ||
|
|
@@ -95,13 +100,13 @@ test-programs = { path = "test-programs" } | |
| tower-service = "0.3.3" | ||
| ureq = { version = "3.1", default-features = false, features = ["json"] } | ||
| wasip2 = "1.0" | ||
| wstd = { path = ".", version = "=0.6.8" } | ||
| wasip3 = "0.8" | ||
| wstd = { path = ".", version = "=0.6.8", default-features = false } | ||
| wstd-axum = { path = "./axum", version = "=0.6.8" } | ||
| wstd-axum-macro = { path = "./axum/macro", version = "=0.6.8" } | ||
| wstd-macro = { path = "./macro", version = "=0.6.8" } | ||
|
|
||
| [package.metadata.docs.rs] | ||
| all-features = true | ||
| targets = [ | ||
| "wasm32-wasip2" | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: it looks like our previous setup was actually running the
stabletoolchain for themsrvandnightlyjobs because the includedrust-toolchain.tomlfile was overriding the default set here.