Repository navigation
fix(render): reject failed required series fetches - #593
Merged
Merged
Conversation
deniszh
approved these changes
Nov 11, 2026
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A render can silently lose a required input when its fetch fails but another leaf succeeds. For example, KO/(KO+OK) evaluates to a fake ratio of 1.0 when OK times out and only KO remains. The incomplete result is returned as HTTP 200 and can be cached. Required fetch failures should produce an execution error before expression evaluation.
Architecture
The zipper merges selected backend replicas, then the render handler gathers leaf requests and evaluates the expression. Replica fan-in still succeeds when another selected replica supplies the series. Empty successful replies cannot recover a failed fetch. An all-failed set is NotFound only when every error is NotFound; transport failures must not be masked by a majority of 404s.
Leaf/subrequest fan-in now propagates every non-NotFound failure. Genuine missing series remain available to functions such as fallbackSeries and sumSeries. Known partial results are excluded from the response cache, including successful computations that tolerate missing inputs. Individual and grouped fetches share the same replica recovery rule. No configuration or compatibility path is added.
This change does not add rediscovery, detect HTTP 200 replies containing all-null data, or establish wildcard completeness when a lower layer has already discarded an error.
Before / after
Validation
go test -mod=vendor -race -tags cairo,nativegzip ./pkg/app/carbonapi -count=1passes on this public base.