Skip to content

More tweaks - #19

Merged
az0 merged 3 commits into
bleachbit:gh-pagesfrom
XhmikosR:xmr/dev
Sep 13, 2026
Merged

az0 merged 3 commits into
bleachbit:gh-pagesfrom
XhmikosR:xmr/dev

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Normally the unit tests skip over any permanent changes to your system, but if you
want to enable destructive tests (which make changes without any confirmation) set
the environment variable `DESTRUCTIVE_TEST=T`. **Use with caution!** Normally you
the environment variable `DESTRUCTIVE_TESTS=T`. **Use with caution!** Normally you

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a typo

@XhmikosR
XhmikosR marked this pull request as ready for review September 13, 2026 15:10
@az0 az0 self-assigned this Sep 13, 2026
Normally the unit tests skip over any permanent changes to your system, but if you
want to enable destructive tests (which make changes without any confirmation) set
the environment variable `DESTRUCTIVE_TEST=T`. **Use with caution!** Normally you
the environment variable `DESTRUCTIVE_TESTS=T`. **Use with caution!** Normally you

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the typo, thank you

@az0

az0 commented Sep 13, 2026

Copy link
Copy Markdown
Member

Thank you for another round of good changes. That includes helpful improvements to my new commit 6a3c2ec .

My only concerns were two things about rendering code blocks.

code blocks with multiple commands

Before the change, no line is prefixed with $ .

image

After the change, only first line is prefixed with $

image

.bat lexer

before change

image

With change, it flags % as unknown token.

image

@XhmikosR
XhmikosR marked this pull request as draft September 13, 2026 18:09
@XhmikosR

Copy link
Copy Markdown
Contributor Author

I'll try to see if the first issue is fixable in an easy way, otherwise I'll drop that patch.

As for the the bat issue, I guess it's a bug in rouge. If it's so important for you, I can change this one back.

@XhmikosR
XhmikosR force-pushed the xmr/dev branch 2 times, most recently from 25cf1c5 to 6f810b9 Compare September 13, 2026 18:27
@XhmikosR

Copy link
Copy Markdown
Contributor Author

I dropped the $ patch for now. It doesn't look like it's doable without a custom plugin, so I don't think it's worth it.

The bat change, I'd keep it personally but I don't think it'll be fixed anytime soon so I reverted that too.

@XhmikosR
XhmikosR marked this pull request as ready for review September 13, 2026 18:27
- Wrap main.js in an IIFE with strict mode
- Only add copy buttons when the Clipboard API is available
- Use a Range to get console commands instead of walking text nodes
- Show "Failed" on copy errors and reset the label timer on repeated clicks
- Move `position: relative`` to CSS and show the button on keyboard focus
@az0
az0 merged commit da62621 into bleachbit:gh-pages Sep 13, 2026
5 checks passed
@az0

az0 commented Sep 13, 2026

Copy link
Copy Markdown
Member

The bat change, I'd keep it personally but I don't think it'll be fixed anytime soon so I reverted that too.

I am open to keeping the bat change

@XhmikosR
XhmikosR deleted the xmr/dev branch September 14, 2026 05:32
@XhmikosR

Copy link
Copy Markdown
Contributor Author

Something is weird with Cloudflare... I keep getting /js/main.js not loaded here. I would suggest that you drop any extra checks you have for docs. It's a static site that's served from GitHub; let them handle bots and traffic...

@az0

az0 commented Sep 15, 2026

Copy link
Copy Markdown
Member

Something is weird with Cloudflare... I keep getting /js/main.js not loaded here. I would suggest that you drop any extra checks you have for docs. It's a static site that's served from GitHub; let them handle bots and traffic...

You're right about the main.js not loading, and it should be fixed now. Thank you

@XhmikosR

Copy link
Copy Markdown
Contributor Author

You still seem to be loading zaraz, whatever that is. If you don't really need it, better drop that too.

@az0

az0 commented Sep 15, 2026

Copy link
Copy Markdown
Member

True. I disabled Zaraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants