Read Babel version from index metadata - #37
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Legacy fallback health links can point to a nonexistent release URL.
Review effort: Lite
Findings: None
What changed in this PR
Adds Babel version extraction from index metadata with legacy URL fallback and updates health response links.
Changes:
- Added Babel version resolution and release URL handling.
- Updated health responses to use the resolved version.
- Added tests for metadata and legacy fallback behavior.
| File | Summary |
|---|---|
tests/test_health.py |
Tests explicit and legacy version sources. |
src/nodenorm/handlers/health.py |
Uses resolved Babel metadata; legacy fallback links may omit the required .md suffix. |
src/nodenorm/babel.py |
Implements Babel version extraction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Addressed the Copilot review concern in d4f5d0a. babel_version_url now targets Babel’s canonical release-notes document at releases/{version}/README.md. Verified both legacy 2025sep1 and current 2026jul22 URLs return HTTP 200, and added exact assertions for both paths. The 10 targeted and adjacent tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.