Normalize digital media in Discogs searches - #6980
Open
sindreruud wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6980 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 163 163
Lines 21627 21629 +2
Branches 3344 3345 +1
=======================================
+ Hits 16621 16623 +2
Misses 4190 4190
Partials 816 816
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Discogs plugin supports
mediaas anextra_tagssearch filter and maps it to Discogs' format parameter.Discogs uses the word
Fileto describe digital releases. MusicBrainz on the other hand uses something different,Digital MediaIf you have music previously tagged against MusicBrainz, the metadata will usually say
Digital Media. I have also seenWEBbeing quite common.As a result, enabling
mediaindiscogs.extra_tagscan negatively impact the search accuracy, while in reality it should not.This PR normalizes
Digital MediaandWEBtoFilewhen constructing the Discogs search filter.PS, this is my first PR in this project. So please let me know if there is something I need to correct. I tried following all the documentation to the best of my knowledge.