Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in Cargo target-context setting for generators implementing resolver-v2 feature separation. Rust rules preserve the original target marker until a dependency enters an execution configuration, then expose the originating triple to host-side selects. An optional per-rule map can share configurations only when the generator knows their dependencies and features are equivalent. Unset contexts remain disabled.
The interface is documented in
docs/cargo_target_context.md;cargo_build_scriptforwards the map to the binary that compiles the script. The setting uses the default universal scope instead of requiring the newer explicitscopeattribute. Transition labels are anchored to rules_rust's repository mapping. The current Rust dylib rule is covered alongside the other library forms.The analysis regressions inspect real Rust library, procedural-macro, host dependency and build-script configurations. They cover the empty default, native contexts, and a Linux target with host-side tools. The cross-platform case uses an analysis-only C++ toolchain and does not attempt to execute a Linux binary on macOS. Existing coverage tests also pass with their marker aligned to the compiler's incoming transition.
Related: hermeticbuild/rules_rs#158 and hermeticbuild/rules_rs#277.
Fixes #4300.
Validation:
bazel test //test/unit/cargo_context:default_test //test/unit/cargo_context:native_test //test/unit/cargo_context:cross_test //test/unit/cargo_context:mapping_test //test/unit/coverage:all(6 tests passed); formatting and whitespace checks passed.