Skip to content

change: update image_uri_configs 09-21-2026 13:30:13 PST - #6297

Open
Yadan-Wei wants to merge 1 commit into
masterfrom
master-rba-v3
Open

Yadan-Wei wants to merge 1 commit into
masterfrom
master-rba-v3

Conversation

@Yadan-Wei

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Claude finished @Yadan-Wei's task in 1m 46s —— View job


PR Review — image_uri_config updates

  • Read the full PR diff
  • Analyze JSON config changes for correctness
  • Check version ordering / aliases / tag structure consistency
  • Post review feedback

This PR is a data-only update to the image_uri_config/*.json files: adding the new me-west-1 region across many configs, backfilling ADC/partition registries (eu-isoe-west-1, eusc-de-east-1, us-iso-east-1, us-isob-east-1, us-isof-east-1, us-isof-south-1), introducing new framework versions (vllm 0.23–0.29, sglang 0.5.13–0.5.20, llama-cpp 1.0.0, ray-serve 1.2/1.3, etc.), and reordering keys within version blocks. No Python/public-API changes, and the account IDs added are the standard public AWS DLC registry accounts, so there are no security concerns.

The changes look mechanically sound (no duplicate JSON keys introduced by the reorderings, and the moved container_version/tag_prefix blocks net out correctly). A few things worth confirming before merge:

1. Missing trailing newline on 10 files (nit, but likely CI-relevant)

The diff shows \ No newline at end of file for:
llama-cpp-arm64.json, llama-cpp.json, pytorch-amzn2023.json, ray-serve.json, sglang-server.json, sglang.json, vllm-omni.json, vllm-server.json, vllm.json, whisperx.json.

These files previously ended with a newline. If the repo runs an end-of-file-fixer / pre-commit / JSON-format check, this will fail. Worth restoring the trailing newline for consistency with the untouched configs (pytorch.json, tensorflow.json, huggingface-llm*.json all keep theirs).

2. Region availability regresses on the newest versions — please confirm intentional

In several files the newest version ships with fewer partitions than the version right before it:

  • vllm.json: 0.27.1 and 0.28.0 include the China/GovCloud/ISO partitions (cn-*, us-gov-*, us-iso*, eusc-de-east-1, eu-isoe-west-1), but the newest 0.29.0 (and 0.23.00.26.0) omit all of them.
  • sglang.json: 0.5.18 includes the full partition set, but the newer 0.5.19/0.5.20 and the 0.5.130.5.17 entries omit cn-*/gov/iso.
  • ray-serve.json: 1.2 and 1.3 omit cn-*/gov/iso while 1 and 1.4 include them.

This is plausibly a staged rollout (image not yet published to those partitions), which is fine — but since 0.29.0 is the newest tag and the 0.29 alias points to it, a retrieve(...) call for these in GovCloud/ISO/China will fail even though an older version works there. Please double-check the omissions are deliberate and not a generation artifact.

3. Version aliases — verified consistent

vllm (0.29 → 0.29.0, 0.25 → 0.25.1, etc.), sglang (0.5 → 0.5.20), and huggingface-llm aliases all resolve to existing version entries. No dangling aliases spotted.

Overall this looks like a routine, low-risk config bump. Items (1) and (2) are the only things I'd want addressed/confirmed.

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.42%. Comparing base (800d342) to head (8409463).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6297      +/-   ##
==========================================
+ Coverage   71.37%   71.42%   +0.05%     
==========================================
  Files         556      556              
  Lines       68598    68598              
==========================================
+ Hits        48960    48996      +36     
+ Misses      19638    19602      -36     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants